You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "John D. Ament (JIRA)" <ji...@apache.org> on 2016/07/21 22:52:20 UTC
[jira] [Comment Edited] (ARTEMIS-649) Replace report generation
with a templating library
[ https://issues.apache.org/jira/browse/ARTEMIS-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388565#comment-15388565 ]
John D. Ament edited comment on ARTEMIS-649 at 7/21/16 10:52 PM:
-----------------------------------------------------------------
I don't think I'm saying this is of any high priority, but definitely something that should be looked into. When swapping out the JSON provider, a test that uses this started failing. it didn't fail on an assertion but because it just makes sure the method runs. There's no verification of the output of the method, which switching to a template library would help fix (separating out the presentation and BL, adding the ability to test a bit more).
Plus velocity is only ~450kb. Shouldn't be that bad to bring in. (freemarker is 790kb).
We can also look at things like mustache, where velocity and mustache are both prepackaged on wildfly. (mustache is only 110kb)
was (Author: johndament):
I don't think I'm saying this is of any high priority, but definitely something that should be looked into. When swapping out the JSON provider, a test that uses this started failing. it didn't fail on an assertion but because it just makes sure the method runs. There's no verification of the output of the method, which switching to a template library would help fix (separating out the presentation and BL, adding the ability to test a bit more).
Plus velocity is only ~450kb. Shouldn't be that bad to bring in. (freemarker is 790kb).
We can also look at things like mustache, where velocity and mustache are both prepackaged on wildfly.
> Replace report generation with a templating library
> ---------------------------------------------------
>
> Key: ARTEMIS-649
> URL: https://issues.apache.org/jira/browse/ARTEMIS-649
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: John D. Ament
>
> ActiveMQServerControlImpl, JMSServerManagerImpl uses Java to generate HTML, for a status report
> This can be done better with templating tools like freemarker or velocity, and alleviate the manual string manipulation. We can also leverage the type safe POJOs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)