You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2023/01/14 23:37:13 UTC
[GitHub] [solr] magibney opened a new pull request, #1291: buildAndPushRelease should optionally pause before assembleRelease
magibney opened a new pull request, #1291:
URL: https://github.com/apache/solr/pull/1291
apache/solr#1125 works around gpg pinentry via a `setup_gpg` step that caches the user pin in `gpg-agent`.
For configurations that require explicit user PIN entry via non-tty-based pinentry program, as discussed in [help/publishing.txt](https://github.com/apache/solr/blob/releases/solr/9.1.0/help/publishing.txt#L125-L128) -- i.e., where gpg-agent is not configured to cache user PIN -- the approach followed in apache/solr#1125 will not work.
In such cases, we should provide the option to pause for user confirmation before proceeding to the `assembleRelease`/signing phase. Without such a pause, it's likely that an RM will step away while tests are running, and once tests complete but before the RM returns, the pinentry prompt will timeout, causing the entire invocation of `buildAndPushRelease.py` to fail unnecessarily (ask me how I know 😁).
This PR, if merged, should ideally be merged after https://github.com/apache/solr/pull/1290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] magibney merged pull request #1291: buildAndPushRelease should optionally pause before assembleRelease
Posted by GitBox <gi...@apache.org>.
magibney merged PR #1291:
URL: https://github.com/apache/solr/pull/1291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] magibney commented on pull request #1291: buildAndPushRelease should optionally pause before assembleRelease
Posted by GitBox <gi...@apache.org>.
magibney commented on PR #1291:
URL: https://github.com/apache/solr/pull/1291#issuecomment-1385592060
Thanks, Kevin and Jan! I did a dry-run of this (and also #1290), and both worked as intended. I'll merge and incorporate testing this out "in real life" while building 9.1.1 RC2.
(It occurred to me: I'll probably change `str(input("[...]")` to be just `input("[...]")` -- we're discarding the input anyway, so there's no point in wrapping it with `str()`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org