You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/31 12:36:45 UTC
[GitHub] [flink-web] XComp opened a new pull request #374: [hotfix] Introduce parameter to make future posts visible in local run
XComp opened a new pull request #374:
URL: https://github.com/apache/flink-web/pull/374
build.sh parameters as part of the run. Additionally, a new parameter
got introduced to build.sh that extends -p to also enable posts
happening in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] rmetzger commented on a change in pull request #374: [hotfix] Introduce parameter to make future posts visible in local run
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #374:
URL: https://github.com/apache/flink-web/pull/374#discussion_r484054394
##########
File path: docker-run.sh
##########
@@ -16,10 +16,4 @@
# limitations under the License.
Review comment:
Maybe calling the file `docker-build.sh` makes more sense, since it's calling the `build.sh` script, and this script wraps it in docker?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] rmetzger commented on a change in pull request #374: [hotfix] Introduce parameter to make future posts visible in local run
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #374:
URL: https://github.com/apache/flink-web/pull/374#discussion_r484054583
##########
File path: docker-run.sh
##########
@@ -16,10 +16,4 @@
# limitations under the License.
Review comment:
@sjwiesman introduced the Makefile like 2 weeks ago. I don't care if it is a makefile or not, but I was wondering if he had a strong reason to add a Makefile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] rmetzger commented on a change in pull request #374: [hotfix] Introduce parameter to make future posts visible in local run
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #374:
URL: https://github.com/apache/flink-web/pull/374#discussion_r484054293
##########
File path: docker-run.sh
##########
@@ -16,10 +16,4 @@
# limitations under the License.
Review comment:
The file misses the shebang.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] XComp commented on a change in pull request #374: [hotfix] Introduce parameter to make future posts visible in local run
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #374:
URL: https://github.com/apache/flink-web/pull/374#discussion_r484289772
##########
File path: docker-run.sh
##########
@@ -16,10 +16,4 @@
# limitations under the License.
Review comment:
I just found it better fitting since we only do parameter passing in the end. I found that the intend of make does not include parameter passing. Is this a correct conclusion? I didn't want to include a third target to support another parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] sjwiesman commented on a change in pull request #374: [hotfix] Introduce parameter to make future posts visible in local run
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on a change in pull request #374:
URL: https://github.com/apache/flink-web/pull/374#discussion_r484084447
##########
File path: docker-run.sh
##########
@@ -16,10 +16,4 @@
# limitations under the License.
Review comment:
No strong reason, I like makefiles :shrug:
Either solution is fine with me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] asfgit closed pull request #374: [hotfix] Introduce parameter to make future posts visible in local run
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #374:
URL: https://github.com/apache/flink-web/pull/374
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org