You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/18 00:06:11 UTC
[GitHub] [incubator-superset] lilykuang opened a new pull request #9577:
feature/add statsd to datasets api
lilykuang opened a new pull request #9577: feature/add statsd to datasets api
URL: https://github.com/apache/incubator-superset/pull/9577
### CATEGORY
Choose one
- [ ] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9577:
[datesets] feat: add statsd to datasets api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9577: [datesets] feat: add statsd to datasets api
URL: https://github.com/apache/incubator-superset/pull/9577#issuecomment-615945115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=h1) Report
> Merging [#9577](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea27e68ee1c746b0daa831765bbadb81a6b2ed0d&el=desc) will **increase** coverage by `4.63%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9577 +/- ##
==========================================
+ Coverage 65.62% 70.26% +4.63%
==========================================
Files 574 574
Lines 30060 30081 +21
Branches 3054 3054
==========================================
+ Hits 19726 21135 +1409
+ Misses 10150 8828 -1322
+ Partials 184 118 -66
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.89% <ø> (?)` | |
| #javascript | `58.75% <ø> (ø)` | |
| #python | `70.45% <100.00%> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.56% <100.00%> (+0.32%)` | :arrow_up: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (+0.65%)` | :arrow_up: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `94.56% <0.00%> (+0.66%)` | :arrow_up: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `53.84% <0.00%> (+1.28%)` | :arrow_up: |
| [superset-frontend/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS5qc3g=) | `81.69% <0.00%> (+1.40%)` | :arrow_up: |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `36.36% <0.00%> (+1.51%)` | :arrow_up: |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (+1.56%)` | :arrow_up: |
| ... and [136 more](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=footer). Last update [ea27e68...99cc2bb](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9577:
[datesets] feat: add statsd to datasets api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9577: [datesets] feat: add statsd to datasets api
URL: https://github.com/apache/incubator-superset/pull/9577#issuecomment-615945115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=h1) Report
> Merging [#9577](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea27e68ee1c746b0daa831765bbadb81a6b2ed0d&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9577 +/- ##
==========================================
- Coverage 65.62% 65.57% -0.05%
==========================================
Files 574 574
Lines 30060 30081 +21
Branches 3054 3054
==========================================
Hits 19726 19726
- Misses 10150 10171 +21
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.75% <ø> (ø)` | |
| #python | `70.36% <100.00%> (-0.09%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.56% <100.00%> (+0.32%)` | :arrow_up: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.75% <0.00%> (-1.17%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `94.56% <0.00%> (+0.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=footer). Last update [ea27e68...99cc2bb](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9577:
[datesets] feat: add statsd to datasets api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9577: [datesets] feat: add statsd to datasets api
URL: https://github.com/apache/incubator-superset/pull/9577#issuecomment-615945115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=h1) Report
> Merging [#9577](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea27e68ee1c746b0daa831765bbadb81a6b2ed0d&el=desc) will **increase** coverage by `4.85%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9577 +/- ##
==========================================
+ Coverage 65.62% 70.47% +4.85%
==========================================
Files 574 574
Lines 30060 30081 +21
Branches 3054 3054
==========================================
+ Hits 19726 21199 +1473
+ Misses 10150 8771 -1379
+ Partials 184 111 -73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.71% <ø> (?)` | |
| #javascript | `58.75% <ø> (ø)` | |
| #python | `70.45% <100.00%> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.56% <100.00%> (+0.32%)` | :arrow_up: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `94.56% <0.00%> (+0.66%)` | :arrow_up: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `56.98% <0.00%> (+1.07%)` | :arrow_up: |
| [superset-frontend/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS5qc3g=) | `81.69% <0.00%> (+1.40%)` | :arrow_up: |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `36.36% <0.00%> (+1.51%)` | :arrow_up: |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (+1.56%)` | :arrow_up: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `81.35% <0.00%> (+1.69%)` | :arrow_up: |
| ... and [138 more](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=footer). Last update [ea27e68...99cc2bb](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request
#9577: [datesets] feat: add statsd to datasets api
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #9577: [datesets] feat: add statsd to datasets api
URL: https://github.com/apache/incubator-superset/pull/9577#discussion_r410721715
##########
File path: superset/datasets/api.py
##########
@@ -344,6 +352,7 @@ def export(self, **kwargs: Any) -> Response:
@expose("/<pk>/refresh", methods=["PUT"])
@protect()
+ @statsd_metrics
Review comment:
Change the position, after the `safe` decorator
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9577:
[datesets] feat: add statsd to datasets api
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9577: [datesets] feat: add statsd to datasets api
URL: https://github.com/apache/incubator-superset/pull/9577#issuecomment-615945115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=h1) Report
> Merging [#9577](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea27e68ee1c746b0daa831765bbadb81a6b2ed0d&el=desc) will **decrease** coverage by `6.86%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9577 +/- ##
==========================================
- Coverage 65.62% 58.75% -6.87%
==========================================
Files 574 392 -182
Lines 30060 12414 -17646
Branches 3054 3054
==========================================
- Hits 19726 7294 -12432
+ Misses 10150 4936 -5214
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.75% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | | |
| [superset/views/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZmlsdGVycy5weQ==) | | |
| [superset/examples/tabbed\_dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdGFiYmVkX2Rhc2hib2FyZC5weQ==) | | |
| [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | | |
| [superset/db\_engine\_specs/cockroachdb.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NvY2tyb2FjaGRiLnB5) | | |
| [superset/utils/url\_map\_converters.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvdXJsX21hcF9jb252ZXJ0ZXJzLnB5) | | |
| [...uperset/utils/dashboard\_filter\_scopes\_converter.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ZpbHRlcl9zY29wZXNfY29udmVydGVyLnB5) | | |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | | |
| [superset/security/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvX19pbml0X18ucHk=) | | |
| [superset/db\_engine\_specs/snowflake.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Nub3dmbGFrZS5weQ==) | | |
| ... and [171 more](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=footer). Last update [ea27e68...99cc2bb](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9577:
[datesets] feat: add statsd to datasets api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9577: [datesets] feat: add statsd to datasets api
URL: https://github.com/apache/incubator-superset/pull/9577#issuecomment-615945115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=h1) Report
> Merging [#9577](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea27e68ee1c746b0daa831765bbadb81a6b2ed0d&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9577 +/- ##
==========================================
- Coverage 65.62% 65.57% -0.05%
==========================================
Files 574 574
Lines 30060 30081 +21
Branches 3054 3054
==========================================
Hits 19726 19726
- Misses 10150 10171 +21
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.75% <ø> (ø)` | |
| #python | `70.36% <100.00%> (-0.09%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.56% <100.00%> (+0.32%)` | :arrow_up: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.75% <0.00%> (-1.17%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `94.56% <0.00%> (+0.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=footer). Last update [ea27e68...99cc2bb](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9577:
[datesets] feat: add statsd to datasets api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9577: [datesets] feat: add statsd to datasets api
URL: https://github.com/apache/incubator-superset/pull/9577#issuecomment-615945115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=h1) Report
> Merging [#9577](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea27e68ee1c746b0daa831765bbadb81a6b2ed0d&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9577 +/- ##
=======================================
Coverage 65.62% 65.62%
=======================================
Files 574 574
Lines 30060 30081 +21
Branches 3054 3054
=======================================
+ Hits 19726 19742 +16
- Misses 10150 10155 +5
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.75% <ø> (ø)` | |
| #python | `70.45% <100.00%> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.56% <100.00%> (+0.32%)` | :arrow_up: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/9577/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `94.56% <0.00%> (+0.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=footer). Last update [ea27e68...99cc2bb](https://codecov.io/gh/apache/incubator-superset/pull/9577?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9577: [datesets] feat: add statsd to datasets api
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #9577:
URL: https://github.com/apache/incubator-superset/pull/9577#discussion_r412023760
##########
File path: tests/datasets/api_tests.py
##########
@@ -662,7 +662,7 @@ def test_dataset_item_refresh(self):
def test_dataset_item_refresh_not_found(self):
"""
- Dataset API: Test item refresh not found dataset
+ Dataset API: Test item refresh not found dataset
Review comment:
Can we add the metric assert here?
##########
File path: tests/datasets/api_tests.py
##########
@@ -673,7 +673,7 @@ def test_dataset_item_refresh_not_found(self):
def test_dataset_item_refresh_not_owned(self):
"""
- Dataset API: Test item refresh not owned dataset
+ Dataset API: Test item refresh not owned dataset
Review comment:
Can we add the metric assert here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #9577: [datesets] feat: add statsd to datasets api
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on issue #9577:
URL: https://github.com/apache/incubator-superset/pull/9577#issuecomment-617062756
Can you please fill the "Summary" to add a bit of context to this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org