You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/04/10 00:54:52 UTC
[kudu-CR] [docs] Add maximum tablet size recommendations
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12979
Change subject: [docs] Add maximum tablet size recommendations
......................................................................
[docs] Add maximum tablet size recommendations
Based primarily on the collective experience of many of
the Kudu committers, this patch attempts to provide
some guardrail limits and recomendations on tablet
size. It doesn’t enumurate all of the issues that occur
with very large tablets, primarily because they are
not all known, but gives some examples of issues
that have been seen as tablets go over the proposed
limit of 50 GiB.
I also updated existing usage of GB/TB to GiB/TiB.
Change-Id: I9fe48e483334812795d124ee63a3af92f39135de
---
M docs/known_issues.adoc
1 file changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/12979/1
--
To view, visit http://gerrit.cloudera.org:8080/12979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fe48e483334812795d124ee63a3af92f39135de
Gerrit-Change-Number: 12979
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [docs] Add maximum tablet size recommendations
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12979 )
Change subject: [docs] Add maximum tablet size recommendations
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fe48e483334812795d124ee63a3af92f39135de
Gerrit-Change-Number: 12979
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Apr 2019 18:35:32 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add maximum tablet size recommendations
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12979 )
Change subject: [docs] Add maximum tablet size recommendations
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fe48e483334812795d124ee63a3af92f39135de
Gerrit-Change-Number: 12979
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Apr 2019 18:15:55 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add maximum tablet size recommendations
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12979 )
Change subject: [docs] Add maximum tablet size recommendations
......................................................................
Patch Set 1:
> although it would be useful to link users to relevant Jiras
The main thing I do not want to indicate is that the jiras I list are the "only" issues, given my examples are not exhaustive because we don't know all the issues or what the next limit would be. Additionally, as we learn more issues I don't want to feel required to update this page since it's meant more for users than contributors and it is only published periodically. Perhaps we can meet in the middle and link to a label in jira that can be updated dynamically as more or less details are found.
That work could be done as a follow up change given many of the items on the list could be tied to a list of jiras for "known" issues.
--
To view, visit http://gerrit.cloudera.org:8080/12979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fe48e483334812795d124ee63a3af92f39135de
Gerrit-Change-Number: 12979
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Apr 2019 23:52:41 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add maximum tablet size recommendations
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [docs] Add maximum tablet size recommendations
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/12979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I9fe48e483334812795d124ee63a3af92f39135de
Gerrit-Change-Number: 12979
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add maximum tablet size recommendations
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12979 )
Change subject: [docs] Add maximum tablet size recommendations
......................................................................
[docs] Add maximum tablet size recommendations
Based primarily on the collective experience of many of
the Kudu committers, this patch attempts to provide
some guardrail limits and recomendations on tablet
size. It doesn’t enumurate all of the issues that occur
with very large tablets, primarily because they are
not all known, but gives some examples of issues
that have been seen as tablets go over the proposed
limit of 50 GiB.
I also updated existing usage of GB/TB to GiB/TiB.
Change-Id: I9fe48e483334812795d124ee63a3af92f39135de
Reviewed-on: http://gerrit.cloudera.org:8080/12979
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Mike Percy <mp...@apache.org>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M docs/known_issues.adoc
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Grant Henke: Verified
Mike Percy: Looks good to me, but someone else must approve
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9fe48e483334812795d124ee63a3af92f39135de
Gerrit-Change-Number: 12979
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add maximum tablet size recommendations
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12979 )
Change subject: [docs] Add maximum tablet size recommendations
......................................................................
Patch Set 1: Code-Review+1
The guardrail numbers look good to me, although it would be useful to link users to relevant Jiras tracking the underlying limitations for the following reasons: 1. contributors who want to help address the issues will know where to look; 2. we will remember the reasons that we decided on these numbers in the future.
--
To view, visit http://gerrit.cloudera.org:8080/12979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fe48e483334812795d124ee63a3af92f39135de
Gerrit-Change-Number: 12979
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Apr 2019 22:56:29 +0000
Gerrit-HasComments: No