You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2017/01/12 11:33:30 UTC

[Bug 60577] New: Mod cache not working, with apache set as forward http proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=60577

            Bug ID: 60577
           Summary: Mod cache not working, with apache set as forward http
                    proxy
           Product: Apache httpd-2
           Version: 2.4.25
          Hardware: PC
            Status: NEW
          Severity: major
          Priority: P2
         Component: mod_cache
          Assignee: bugs@httpd.apache.org
          Reporter: kudlacak1@gmail.com
  Target Milestone: ---

Created attachment 34612
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34612&action=edit
Configuration of httpd

When apache is set as forward http proxy, CacheEnable disk http://, should
cache all http content and it is not working (CacheQuickHandler is Off). It
should be caused by this commit:
https://github.com/apache/httpd/commit/cc21a5acc79e1d8522373061dd3c2e91487bdc7b
by comparing uri and path in file modules/cache/cache_util.c. Complete
configuration attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 60577] Mod cache not working, with apache set as forward http proxy

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60577

Yann Ylavic <yl...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34616|0                           |1
        is obsolete|                            |

--- Comment #5 from Yann Ylavic <yl...@gmail.com> ---
Created attachment 34770
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34770&action=edit
Early vs final URIs used by mod_cache

Depending on whether mod_cache runs in forward proxy and quick handler modes,
or normal handler mode, its base path and query string
references/canonicalizations are not computed at the same time (before or after
quick_handler and proxy_detect transforms) and thus may differ.

This patch defines the cache_use_early_url() helper and use it wherever
appropriate for mod_cache to consistently refer to the same entity while
serving and/or caching the response, in both early and late cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 60577] Mod cache not working, with apache set as forward http proxy

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60577

--- Comment #2 from Jim Jagielski <ji...@apache.org> ---
Thanks. Will review.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 60577] Mod cache not working, with apache set as forward http proxy

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60577

Yann Ylavic <yl...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |FixedInTrunk

--- Comment #7 from Yann Ylavic <yl...@gmail.com> ---
Thanks all for the test(s), committed to trunk (r1783842) and proposed for
backport to 2.4.x.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 60577] Mod cache not working, with apache set as forward http proxy

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60577

Eric Covener <co...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Eric Covener <co...@gmail.com> ---
fixed in 2.4.25 with a followup in .26

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 60577] Mod cache not working, with apache set as forward http proxy

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60577

Jim Jagielski <ji...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jim@apache.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 60577] Mod cache not working, with apache set as forward http proxy

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60577

--- Comment #1 from Petr Sumbera <pe...@oracle.com> ---
Created attachment 34613
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34613&action=edit
Possible patch

We are hiting the same issue with 2.4.25. Attached is patch which seems to
resolve the issue (uses the same value as 2.4.23 did).

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 60577] Mod cache not working, with apache set as forward http proxy

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60577

--- Comment #3 from Yann Ylavic <yl...@gmail.com> ---
Created attachment 34616
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34616&action=edit
Another proposed patch

Wouldn't this patch be better?

One might still want to cache based on the rewritten URL, and attachment 34613
reverts that (was the purpose of r1756553).

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 60577] Mod cache not working, with apache set as forward http proxy

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60577

--- Comment #4 from Petr Sumbera <pe...@oracle.com> ---
I'm not expert here. I can just confirm that 34616 makes our test case to pass.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 60577] Mod cache not working, with apache set as forward http proxy

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60577

--- Comment #6 from Petr Gajdos <pg...@suse.cz> ---
Hey,

I can confirm, that following example ([2] subexample, forward proxy):

https://github.com/pgajdos/apache-rex/tree/master/mod_proxy-cache

fails before and pass after the patch in comment 5 on the top of 2.4.25.

Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 60577] Mod cache not working, with apache set as forward http proxy

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60577

Petr Gajdos <pg...@suse.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pgajdos@suse.cz

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 60577] Mod cache not working, with apache set as forward http proxy

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60577

Petr Sumbera <pe...@oracle.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All
                 CC|                            |petr.sumbera@oracle.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org