(commons-crypto) branch master updated: Target documentation [skip ci]

[se...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-crypto.git


The following commit(s) were added to refs/heads/master by this push:
     new 016701ed Target documentation [skip ci]
016701ed is described below

commit 016701edd9d77037642f12bf4b3ef65232000de7
Author: Sebb <se...@apache.org>
AuthorDate: Wed Nov 1 11:41:26 2023 +0000

    Target documentation [skip ci]
---
 Makefile        | 2 ++
 Makefile.common | 4 +++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 12d6ea91..9ac28579 100644
--- a/Makefile
+++ b/Makefile
@@ -83,6 +83,8 @@ $(NATIVE_DLL): $(COMMONS_CRYPTO_OUT)/$(LIBNAME)
 	@mkdir -p $(@D)
 	cp $< $@
 
+# These targets should correspond with the entries in the list 'known_os_archs' defined in Makefile.common
+# e.g. linux32 corresponds with Linux-x86
 win32:
 	$(MAKE) native CROSS_PREFIX=i686-w64-mingw32- OS_NAME=Windows OS_ARCH=x86
 
diff --git a/Makefile.common b/Makefile.common
index 900b3c5f..44d63406 100644
--- a/Makefile.common
+++ b/Makefile.common
@@ -52,7 +52,9 @@ endif
 
 
 # os=Default is meant to be generic Unix/Linux
-# The following list must include all OS entries beloe (apart from Default)
+# The following list must include all OS entries below (apart from Default)
+# Also there should be a target in the makefile for each of the combinations
+# For example, 'Linux-x86' is invoked by the target 'linux32'
 known_os_archs := Linux-x86 Linux-x86_64 Linux-aarch64 Linux-arm Linux-armhf Linux-ppc Linux-ppc64 Mac-x86 Mac-x86_64 Mac-arm64 Mac-aarch64 FreeBSD-x86_64 Windows-x86 Windows-x86_64 SunOS-x86 SunOS-sparc SunOS-x86_64 AIX-ppc64
 os_arch := $(OS_NAME)-$(OS_ARCH)