[GitHub] williaster commented on issue #5771: [dashboard] Add alert when user deleting root level tab

[GitBox <gi...@apache.org>]

williaster commented on issue #5771: [dashboard] Add alert when user deleting root level tab
URL: https://github.com/apache/incubator-superset/pull/5771#issuecomment-417070236
 
 
   @graceguo-supercat great change!
   
   A couple of aesthetic comments:
   - there looks like there's double padding between the buttons, could we cut it in half?
   - could we update the messaging to the following (minor tweaks, I don't think the warning/note keywords are needed since we're using a modal):
   
   """
   **Delete dashboard tab?**
   
   Deleting a tab will remove all content within it. You may still reverse this action with the **undo** button (...+ z) until you save your changes.
   """
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org