You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/03/21 17:56:14 UTC

[GitHub] [pulsar] cckellogg commented on a change in pull request #3874: [ISSUE 3763] - Implementing Function authorization

cckellogg commented on a change in pull request #3874: [ISSUE 3763] - Implementing Function authorization
URL: https://github.com/apache/pulsar/pull/3874#discussion_r267882644
 
 

 ##########
 File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/Worker.java
 ##########
 @@ -38,6 +50,13 @@
     private final WorkerService workerService;
     private WorkerServer server;
 
+    private ZooKeeperClientFactory zkClientFactory = null;
 
 Review comment:
   Curious as to why the worker server needs access to zookeeper? Can we just pass the Authorization provider to the worker and decouple the implementation?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services