[GitHub] [calcite] julianhyde commented on a change in pull request #2444: [CALCITE-4644] Added PERCENTILE_CONT and PERCENTILE_DISC functions in…

[GitBox <gi...@apache.org>]

julianhyde commented on a change in pull request #2444:
URL: https://github.com/apache/calcite/pull/2444#discussion_r656342964



##########
File path: core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java
##########
@@ -369,6 +369,49 @@ private boolean hasFractionalPart(BigDecimal bd) {
         }
       };
 
+  /**
+   * Operand type-checking strategy type must be a positive numeric non-NULL
+   * literal in the range 0 - 1.
+   */
+  public static final SqlSingleOperandTypeChecker POSITIVE_NUMERIC_LITERAL =

Review comment:
       Let's find a better name than 'positive'. Positive means 'greater than zero'. So your use of it here is misleading.
   
   You seem to need something in the range 0 to 1, including both end points. That's a fairly common notion, so there must be a word for it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org