[GitHub] [flink-statefun] igalshilman commented on a change in pull request #27: [FLINK-16149][core] Set configurations using StreamExecutionEnvironment#getConfiguration

[GitBox <gi...@apache.org>]

igalshilman commented on a change in pull request #27: [FLINK-16149][core] Set configurations using StreamExecutionEnvironment#getConfiguration
URL: https://github.com/apache/flink-statefun/pull/27#discussion_r381932931
 
 

 ##########
 File path: statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/StatefulFunctionsJob.java
 ##########
 @@ -17,59 +17,62 @@
  */
 package org.apache.flink.statefun.flink.core;
 
+import java.io.File;
 import java.net.URL;
 import java.net.URLClassLoader;
+import java.util.Map;
 import java.util.Objects;
 import org.apache.flink.api.java.utils.ParameterTool;
+import org.apache.flink.configuration.ConfigConstants;
 import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.GlobalConfiguration;
 import org.apache.flink.runtime.execution.librarycache.FlinkUserCodeClassLoaders;
-import org.apache.flink.statefun.flink.core.common.ConfigurationUtil;
 import org.apache.flink.statefun.flink.core.translation.FlinkUniverse;
 import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
 
+@SuppressWarnings("JavaReflectionMemberAccess")
 public class StatefulFunctionsJob {
 
+  private static final String CONFIG_DIRECTORY_FALLBACK_1 = "../conf";
 
 Review comment:
   Can all the `flink-conf.yaml` related search and parsing be extract to an external class?
   perhaps ConfUtils or something like that?
   Also it should probably LOG where did it got their configurations.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services