You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iotdb.apache.org by "Tian Jiang (Jira)" <ji...@apache.org> on 2019/10/29 03:48:00 UTC

[jira] [Created] (IOTDB-276) Inconsistent ways of judging the nullness of a Field

Tian Jiang created IOTDB-276:
--------------------------------

             Summary: Inconsistent ways of judging the nullness of a Field
                 Key: IOTDB-276
                 URL: https://issues.apache.org/jira/browse/IOTDB-276
             Project: Apache IoTDB
          Issue Type: Bug
            Reporter: Tian Jiang
         Attachments: image-2019-10-29-11-43-40-180.png, image-2019-10-29-11-45-53-763.png

Several places are using the `dataType == null` to judge whether a field is null or not, while there is a field `isNull` which better suits this job.
The inconsistent usages may result in that one sets `isNull` to true but find that the displayed result is not null.
 !image-2019-10-29-11-43-40-180.png|thumbnail! 
 !image-2019-10-29-11-45-53-763.png|thumbnail! 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [jira] [Created] (IOTDB-276) Inconsistent ways of judging the nullness of a Field

Posted by 孙泽嵩 <sz...@mails.tsinghua.edu.cn>.
Hi,

Thanks to @Lei Rui’s precious work and idea, I have fixed this issue by removing isNull field and setNull method. Only retain one way of defining a null field new Field(null), and isNull() method can be realized by checking this.dataType == null.

Here is the PR [1], and if you have any suggestions, please feel free to discuss with me.

[1] https://github.com/apache/incubator-iotdb/pull/517

Best,
-----------------------------------
Zesong Sun
School of Software, Tsinghua University

孙泽嵩
清华大学 软件学院

> 2019年10月29日 11:48，Tian Jiang (Jira) <ji...@apache.org> 写道：
> 
> Tian Jiang created IOTDB-276:
> --------------------------------
> 
>             Summary: Inconsistent ways of judging the nullness of a Field
>                 Key: IOTDB-276
>                 URL: https://issues.apache.org/jira/browse/IOTDB-276
>             Project: Apache IoTDB
>          Issue Type: Bug
>            Reporter: Tian Jiang
>         Attachments: image-2019-10-29-11-43-40-180.png, image-2019-10-29-11-45-53-763.png
> 
> Several places are using the `dataType == null` to judge whether a field is null or not, while there is a field `isNull` which better suits this job.
> The inconsistent usages may result in that one sets `isNull` to true but find that the displayed result is not null.
> !image-2019-10-29-11-43-40-180.png|thumbnail! 
> !image-2019-10-29-11-45-53-763.png|thumbnail! 
> 
> 
> 
> --
> This message was sent by Atlassian Jira
> (v8.3.4#803005)