You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Huaisi Xu (Code Review)" <ge...@cloudera.org> on 2016/03/26 00:47:10 UTC
[Impala-CR](cdh5-2.2.0_5.4.x) IMPALA-2722: Free local allocations per row batch in non-partitioned AGG and HJ
Hello Marcel Kornacker, Matthew Jacobs, Internal Jenkins, Dan Hecht, Tim Armstrong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/2637
to review the following change.
Change subject: IMPALA-2722: Free local allocations per row batch in non-partitioned AGG and HJ
......................................................................
IMPALA-2722: Free local allocations per row batch in non-partitioned AGG and HJ
The fix of IMPALA-2612 added a test which verifies that the memory
limit is not exceeded for the given query if local allocations are
freed per processed row batch. The test fails when PHJ is disabled
as the same bug (of missing free calls to local allocations) also
exists in the non-partitioned counterpart of PAGG and PHJ. This
change fixes both non-partitioned AGG and HJ nodes so local
allocations are freed per row batch.
Change-Id: I9aec4d1fb4f8d52fcdf67f1ca545efa698764f84
Reviewed-on: http://gerrit.cloudera.org:8080/1569
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Reviewed-by: Dan Hecht <dh...@cloudera.com>
Reviewed-by: Marcel Kornacker <ma...@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit ff75c9cde1f6554e7d7cef0b06af366eeabc0a1a)
---
M be/src/exec/aggregation-node.cc
M be/src/exec/hash-join-node.cc
2 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/37/2637/1
--
To view, visit http://gerrit.cloudera.org:8080/2637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9aec4d1fb4f8d52fcdf67f1ca545efa698764f84
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.2.0_5.4.x
Gerrit-Owner: Huaisi Xu <hx...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>