You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2021/12/08 09:21:54 UTC

[GitHub] [incubator-inlong] inter12 commented on a change in pull request #1918: [INLONG-1911] add pulling metric of prometheus, pulling metric value will not be resetted.

inter12 commented on a change in pull request #1918:
URL: https://github.com/apache/incubator-inlong/pull/1918#discussion_r764682217



##########
File path: inlong-dataproxy/dataproxy-source/pom.xml
##########
@@ -46,19 +46,13 @@
 		<dependency>
 			<groupId>org.powermock</groupId>
 			<artifactId>powermock-module-junit4</artifactId>
-			<version>2.0.2</version>
+			<version>${powermock.version}</version>

Review comment:
       dependencymanagement

##########
File path: inlong-dataproxy/dataproxy-source/pom.xml
##########
@@ -46,19 +46,13 @@
 		<dependency>
 			<groupId>org.powermock</groupId>
 			<artifactId>powermock-module-junit4</artifactId>
-			<version>2.0.2</version>
+			<version>${powermock.version}</version>

Review comment:
       The third-party dependent version needs to be external to the parent pom  <dependencymanagement> file




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org