You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2016/07/13 15:34:41 UTC
[GitHub] zeppelin pull request #1182: [HOTFIX] ZEPPELIN-1170 Handsontable fails to di...
GitHub user r-kamath opened a pull request:
https://github.com/apache/zeppelin/pull/1182
[HOTFIX] ZEPPELIN-1170 Handsontable fails to display data on second run
### What is this PR for?
Handsontable fails to display data on second run if first run did not render table due to an error the query.
Fix for a render issue caused by #1059
### What type of PR is it?
Bug Fix, Hot Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1170
### How should this be tested?
Please ref the screenshots
### Screenshots (if appropriate)
**Before**
**After**
### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/r-kamath/zeppelin ZEPPELIN-1170
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1182.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1182
----
commit d63d517ae2bcd12047b390e0723c3ecd2cd8f1e8
Author: Renjith Kamath <re...@gmail.com>
Date: 2016-07-13T15:31:22Z
ZEPPELIN-1170 Handsontable fails to display data on second run
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1182: [HOTFIX] ZEPPELIN-1170 Handsontable fails to display d...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1182
@r-kamath Thanks for the fix. How this fix is different from #1171 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1182: [HOTFIX] ZEPPELIN-1170 Handsontable fails to display d...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1182
LGTM!
This has been happening in my machine as well for quite some time. Thanks @r-kamath for the fix.
@corneadoug, @Leemoonsoo Please review will merge this a hot fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1182: [HOTFIX] ZEPPELIN-1170 Handsontable fails to display d...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/1182
@Leemoonsoo if #1171 is ready to merge. Please feel free to discard this PR and mark the jira issue as duplicate. Thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1182: ZEPPELIN-1170 Handsontable fails to display dat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1182: ZEPPELIN-1170 Handsontable fails to display data on se...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1182
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1182: [HOTFIX] ZEPPELIN-1170 Handsontable fails to display d...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/1182
@Leemoonsoo My bad, I missed your PR.
Difference in #1171 and this pr
- `$scope.hot = null;` is not necessary
- `updateSettings` to update resultRows is one more call and is not doing anything significant
Otherwise the change is pretty much same.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1182: ZEPPELIN-1170 Handsontable fails to display data on se...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1182
@corneadoug from what you say, it's still not clear what's the plan with this one.
I do not think it was rebased, where `rebased = git rebase` - that way all the commits would show up AFTER the conversation as history get's re-written.
Also we would not have commit messages like "Merge remote-tracking branch 'upstream/master' into ZEPPELIN-1170" in case of rebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1182: ZEPPELIN-1170 Handsontable fails to display data on se...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1182
Tested, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1182: [HOTFIX] ZEPPELIN-1170 Handsontable fails to display d...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1182
I think we can merge #1171 and then merge #1182, while this PR includes different improvements. (`$scope.hot = null` and `updateSettings`)
I didn't marked #1171 as a hotfix, but let me merge #1171 quickly, and then let's merge #1182.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1182: ZEPPELIN-1170 Handsontable fails to display data on se...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1182
#1171 is merged already, and this one has been rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1182: ZEPPELIN-1170 Handsontable fails to display data on se...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1182
So what is the consensus, shall we actually *rebase* this one on master and merge, or just close, as soon as #1171 is merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1182: ZEPPELIN-1170 Handsontable fails to display data on se...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1182
@Leemoonsoo Yes, I agree, we should merge #1171.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---