You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/06/17 07:13:15 UTC
[GitHub] [dubbo-go-hessian2] pantianying opened a new pull request #203: Fix: eunm encode in request get error
pantianying opened a new pull request #203:
URL: https://github.com/apache/dubbo-go-hessian2/pull/203
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
fix the bug when eunm encode in request。
**Which issue(s) this PR fixes**:
https://github.com/apache/dubbo-go-hessian2/issues/187
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] zouyx commented on a change in pull request #203: Fix: eunm encode in request get error
Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #203:
URL: https://github.com/apache/dubbo-go-hessian2/pull/203#discussion_r442129255
##########
File path: go.mod
##########
@@ -5,3 +5,5 @@ require (
github.com/pkg/errors v0.9.1
github.com/stretchr/testify v1.4.0
)
+
+go 1.13
Review comment:
should remove it？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo merged pull request #203: Fix: eunm encode in request get error
Posted by GitBox <gi...@apache.org>.
wongoo merged pull request #203:
URL: https://github.com/apache/dubbo-go-hessian2/pull/203
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks commented on pull request #203: Fix: eunm encode in request get error
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #203:
URL: https://github.com/apache/dubbo-go-hessian2/pull/203#issuecomment-645266962
Pls add an ut.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org