You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/15 11:28:40 UTC

[GitHub] [flink] xiaoHoly commented on a change in pull request #14387: [FLINK-19691][Connector][jdbc] Expose `CONNECTION_CHECK_TIMEOUT_SECONDS` as a configurable option in Jdbc connector

xiaoHoly commented on a change in pull request #14387:
URL: https://github.com/apache/flink/pull/14387#discussion_r543264307



##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/options/JdbcOptions.java
##########
@@ -100,14 +100,20 @@ public Builder setUsername(String username) {
 			return this;
 		}
 
+		/**
+		 * optional, CONNECTION_CHECK_TIMEOUT_SECONDS.
+		 */
+		public Builder setCONNECTION_CHECK_TIMEOUT_SECONDS(int setCONNECTION_CHECK_TIMEOUT_SECONDS) {

Review comment:
       > Please keep the parameters named with camel case.
   
   thanks，i will keep it now




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org