You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pankajastro (via GitHub)" <gi...@apache.org> on 2023/02/03 09:00:03 UTC
[GitHub] [airflow] pankajastro opened a new pull request, #29348: Don't push secret in XCOM in BigQueryCreateDataTransferOperator
pankajastro opened a new pull request, #29348:
URL: https://github.com/apache/airflow/pull/29348
closes: https://github.com/apache/airflow/issues/29209
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pankajastro commented on pull request #29348: Don't push secret in XCOM in BigQueryCreateDataTransferOperator
Posted by "pankajastro (via GitHub)" <gi...@apache.org>.
pankajastro commented on PR #29348:
URL: https://github.com/apache/airflow/pull/29348#issuecomment-1437626057
> > And I guess we need to add tests for that, for avoid situation that somehow it return in the future.
>
> Agree
Added here 4eade3237e25f92095d74b76cd1f16f99945c842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #29348: Don't push secret in XCOM in BigQueryCreateDataTransferOperator
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29348:
URL: https://github.com/apache/airflow/pull/29348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #29348: Don't push secret in XCOM in BigQueryCreateDataTransferOperator
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on PR #29348:
URL: https://github.com/apache/airflow/pull/29348#issuecomment-1435774443
And I guess we need to add tests for that, for avoid situation that somehow it return in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29348: Don't push secret in XCOM in BigQueryCreateDataTransferOperator
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29348:
URL: https://github.com/apache/airflow/pull/29348#issuecomment-1437563814
> And I guess we need to add tests for that, for avoid situation that somehow it return in the future.
Agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org