You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/21 08:27:54 UTC
[GitHub] [incubator-shardingsphere] wqzwh opened a new pull request #4399:
sharding-scaling-ui fix details
wqzwh opened a new pull request #4399: sharding-scaling-ui fix details
URL: https://github.com/apache/incubator-shardingsphere/pull/4399
Fixes #4234 .
Changes proposed in this pull request:
- 1. Refresh the data scaling page after the service is configured. The service is not displayed
- 2. Entering data scaling for the first time is to report an error rather than pop-up the window for filling
- 3. Progress details page, progress will not be automatically updated, the window needs to be closed and reopened
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4399:
sharding-scaling-ui fix details
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4399: sharding-scaling-ui fix details
URL: https://github.com/apache/incubator-shardingsphere/pull/4399#issuecomment-589560527
## Pull Request Test Coverage Report for [Build 9686](https://coveralls.io/builds/28874261)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **64.699%**
---
| Totals | [](https://coveralls.io/builds/28874261) |
| :-- | --: |
| Change from base [Build 9664](https://coveralls.io/builds/28847332): | 0.0% |
| Covered Lines: | 11015 |
| Relevant Lines: | 17025 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4399: sharding-scaling-ui fix details
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4399: sharding-scaling-ui fix details
URL: https://github.com/apache/incubator-shardingsphere/pull/4399#issuecomment-589560527
## Pull Request Test Coverage Report for [Build 1828](https://coveralls.io/builds/28874545)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.006%**) to **64.705%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28874545/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L74) | 2 | 80.0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/28874545) |
| :-- | --: |
| Change from base [Build 9664](https://coveralls.io/builds/28847332): | 0.006% |
| Covered Lines: | 11016 |
| Relevant Lines: | 17025 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4399:
sharding-scaling-ui fix details
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4399: sharding-scaling-ui fix details
URL: https://github.com/apache/incubator-shardingsphere/pull/4399#issuecomment-589558828
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4399?src=pr&el=h1) Report
> Merging [#4399](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4399?src=pr&el=desc) into [sharding-scaling-ui](https://codecov.io/gh/apache/incubator-shardingsphere/commit/cc394300c5fb6b6b04fe3cd33a1bf68d6cf2d984?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4399?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## sharding-scaling-ui #4399 +/- ##
=====================================================
Coverage 60.8% 60.8%
Complexity 352 352
=====================================================
Files 1012 1012
Lines 17025 17025
Branches 3004 3004
=====================================================
Hits 10352 10352
Misses 6020 6020
Partials 653 653
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4399?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4399?src=pr&el=footer). Last update [cc39430...f720159](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4399?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4399: sharding-scaling-ui fix details
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4399: sharding-scaling-ui fix details
URL: https://github.com/apache/incubator-shardingsphere/pull/4399#issuecomment-589560527
## Pull Request Test Coverage Report for [Build 1830](https://coveralls.io/builds/28875217)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.006%**) to **64.705%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28875217/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L74) | 2 | 80.0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/28875217) |
| :-- | --: |
| Change from base [Build 9664](https://coveralls.io/builds/28847332): | 0.006% |
| Covered Lines: | 11016 |
| Relevant Lines: | 17025 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4399: sharding-scaling-ui fix details
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4399: sharding-scaling-ui fix details
URL: https://github.com/apache/incubator-shardingsphere/pull/4399#issuecomment-589560527
## Pull Request Test Coverage Report for [Build 9687](https://coveralls.io/builds/28874663)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **64.699%**
---
| Totals | [](https://coveralls.io/builds/28874663) |
| :-- | --: |
| Change from base [Build 9664](https://coveralls.io/builds/28847332): | 0.0% |
| Covered Lines: | 11015 |
| Relevant Lines: | 17025 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4399: sharding-scaling-ui fix details
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4399: sharding-scaling-ui fix details
URL: https://github.com/apache/incubator-shardingsphere/pull/4399#issuecomment-589560527
## Pull Request Test Coverage Report for [Build 1827](https://coveralls.io/builds/28874325)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.006%**) to **64.705%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28874325/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L74) | 2 | 80.0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/28874325) |
| :-- | --: |
| Change from base [Build 9664](https://coveralls.io/builds/28847332): | 0.006% |
| Covered Lines: | 11016 |
| Relevant Lines: | 17025 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion merged pull request #4399:
sharding-scaling-ui fix details
Posted by GitBox <gi...@apache.org>.
KomachiSion merged pull request #4399: sharding-scaling-ui fix details
URL: https://github.com/apache/incubator-shardingsphere/pull/4399
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on a change in
pull request #4399: sharding-scaling-ui fix details
Posted by GitBox <gi...@apache.org>.
KomachiSion commented on a change in pull request #4399: sharding-scaling-ui fix details
URL: https://github.com/apache/incubator-shardingsphere/pull/4399#discussion_r382455062
##########
File path: shardingsphere-ui/shardingsphere-ui-frontend/src/views/data-scaling/module/index.vue
##########
@@ -24,7 +24,7 @@
icon="el-icon-plus"
@click="add">{{ $t('dataScaling.btnTxt') }}</el-button>
<span style="margin-left: 20px;">
- server: <samp style="color: #E17425;">{{ serviceForm.serviceName }}</samp>
+ server: <samp style="color: #E17425;">{{ serviceForm.serviceUrl }}</samp>
Review comment:
I think there should show the serviceName rather than url
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4399: sharding-scaling-ui fix details
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4399: sharding-scaling-ui fix details
URL: https://github.com/apache/incubator-shardingsphere/pull/4399#issuecomment-589560527
## Pull Request Test Coverage Report for [Build 1831](https://coveralls.io/builds/28875268)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.006%**) to **64.705%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28875268/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L74) | 2 | 80.0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/28875268) |
| :-- | --: |
| Change from base [Build 9664](https://coveralls.io/builds/28847332): | 0.006% |
| Covered Lines: | 11016 |
| Relevant Lines: | 17025 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services