You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jérémie BORDIER (JIRA)" <ji...@apache.org> on 2008/12/29 22:10:44 UTC
[jira] Created: (THRIFT-244) JSON Protocol doesn't extends
TProtocolFactory and doesn't write messages begin properly
JSON Protocol doesn't extends TProtocolFactory and doesn't write messages begin properly
----------------------------------------------------------------------------------------
Key: THRIFT-244
URL: https://issues.apache.org/jira/browse/THRIFT-244
Project: Thrift
Issue Type: Bug
Components: Library (C++)
Reporter: Jérémie BORDIER
The trunk cpp JSON protocol doesn't work because of two small issues:
- First part of the writeMessageBegin protocol is to write the Thrift Protocol version, which is stored in a uint8_t static variable. Unfortunately boost::lexical_cast handles uint8_t as a string type and doesn't write the given number. Fixed by moving the variable from uint8_t to uint32_t.
- The current JSONProtocolFactory implements TProtocolFactory but doesn't extend it, so it unuseable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-244) JSON Protocol doesn't extends
TProtocolFactory and doesn't write messages begin properly
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661026#action_12661026 ]
T Jake Luciani commented on THRIFT-244:
---------------------------------------
This looks good to me. I'll verify with David before I commit.
> JSON Protocol doesn't extends TProtocolFactory and doesn't write messages begin properly
> ----------------------------------------------------------------------------------------
>
> Key: THRIFT-244
> URL: https://issues.apache.org/jira/browse/THRIFT-244
> Project: Thrift
> Issue Type: Bug
> Components: Library (C++)
> Reporter: Jérémie BORDIER
> Attachments: cpp_JSONProtocol_factory_writeMessageBegin.patch
>
>
> The trunk cpp JSON protocol doesn't work because of two small issues:
> - First part of the writeMessageBegin protocol is to write the Thrift Protocol version, which is stored in a uint8_t static variable. Unfortunately boost::lexical_cast handles uint8_t as a string type and doesn't write the given number. Fixed by moving the variable from uint8_t to uint32_t.
> - The current JSONProtocolFactory implements TProtocolFactory but doesn't extend it, so it unuseable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-244) JSON Protocol doesn't extends
TProtocolFactory and doesn't write messages begin properly
Posted by "Jérémie BORDIER (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jérémie BORDIER updated THRIFT-244:
-----------------------------------
Attachment: cpp_JSONProtocol_factory_writeMessageBegin.patch
> JSON Protocol doesn't extends TProtocolFactory and doesn't write messages begin properly
> ----------------------------------------------------------------------------------------
>
> Key: THRIFT-244
> URL: https://issues.apache.org/jira/browse/THRIFT-244
> Project: Thrift
> Issue Type: Bug
> Components: Library (C++)
> Reporter: Jérémie BORDIER
> Attachments: cpp_JSONProtocol_factory_writeMessageBegin.patch
>
>
> The trunk cpp JSON protocol doesn't work because of two small issues:
> - First part of the writeMessageBegin protocol is to write the Thrift Protocol version, which is stored in a uint8_t static variable. Unfortunately boost::lexical_cast handles uint8_t as a string type and doesn't write the given number. Fixed by moving the variable from uint8_t to uint32_t.
> - The current JSONProtocolFactory implements TProtocolFactory but doesn't extend it, so it unuseable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-244) JSON Protocol doesn't extends
TProtocolFactory and doesn't write messages begin properly
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss resolved THRIFT-244.
--------------------------------
Resolution: Fixed
Assignee: Jérémie BORDIER
> JSON Protocol doesn't extends TProtocolFactory and doesn't write messages begin properly
> ----------------------------------------------------------------------------------------
>
> Key: THRIFT-244
> URL: https://issues.apache.org/jira/browse/THRIFT-244
> Project: Thrift
> Issue Type: Bug
> Components: Library (C++)
> Reporter: Jérémie BORDIER
> Assignee: Jérémie BORDIER
> Attachments: cpp_JSONProtocol_factory_writeMessageBegin.patch
>
>
> The trunk cpp JSON protocol doesn't work because of two small issues:
> - First part of the writeMessageBegin protocol is to write the Thrift Protocol version, which is stored in a uint8_t static variable. Unfortunately boost::lexical_cast handles uint8_t as a string type and doesn't write the given number. Fixed by moving the variable from uint8_t to uint32_t.
> - The current JSONProtocolFactory implements TProtocolFactory but doesn't extend it, so it unuseable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-244) JSON Protocol doesn't extends
TProtocolFactory and doesn't write messages begin properly
Posted by "Jérémie BORDIER (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664330#action_12664330 ]
Jérémie BORDIER commented on THRIFT-244:
----------------------------------------
Jake ? David ? Could someone apply this ? thanks :)
> JSON Protocol doesn't extends TProtocolFactory and doesn't write messages begin properly
> ----------------------------------------------------------------------------------------
>
> Key: THRIFT-244
> URL: https://issues.apache.org/jira/browse/THRIFT-244
> Project: Thrift
> Issue Type: Bug
> Components: Library (C++)
> Reporter: Jérémie BORDIER
> Attachments: cpp_JSONProtocol_factory_writeMessageBegin.patch
>
>
> The trunk cpp JSON protocol doesn't work because of two small issues:
> - First part of the writeMessageBegin protocol is to write the Thrift Protocol version, which is stored in a uint8_t static variable. Unfortunately boost::lexical_cast handles uint8_t as a string type and doesn't write the given number. Fixed by moving the variable from uint8_t to uint32_t.
> - The current JSONProtocolFactory implements TProtocolFactory but doesn't extend it, so it unuseable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-244) JSON Protocol doesn't extends
TProtocolFactory and doesn't write messages begin properly
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661027#action_12661027 ]
David Reiss commented on THRIFT-244:
------------------------------------
LGTM.
> JSON Protocol doesn't extends TProtocolFactory and doesn't write messages begin properly
> ----------------------------------------------------------------------------------------
>
> Key: THRIFT-244
> URL: https://issues.apache.org/jira/browse/THRIFT-244
> Project: Thrift
> Issue Type: Bug
> Components: Library (C++)
> Reporter: Jérémie BORDIER
> Attachments: cpp_JSONProtocol_factory_writeMessageBegin.patch
>
>
> The trunk cpp JSON protocol doesn't work because of two small issues:
> - First part of the writeMessageBegin protocol is to write the Thrift Protocol version, which is stored in a uint8_t static variable. Unfortunately boost::lexical_cast handles uint8_t as a string type and doesn't write the given number. Fixed by moving the variable from uint8_t to uint32_t.
> - The current JSONProtocolFactory implements TProtocolFactory but doesn't extend it, so it unuseable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.