You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sebastianliebscher (via GitHub)" <gi...@apache.org> on 2023/04/06 21:04:37 UTC
[GitHub] [superset] sebastianliebscher opened a new pull request, #23618: docs(docker): update README
sebastianliebscher opened a new pull request, #23618:
URL: https://github.com/apache/superset/pull/23618
### SUMMARY
The README currently only shows the possibility to define variables via .env file. This PR adds an alternative option to the Docker README for passing variables via docker-compose file. This might make deployment easier for some users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a diff in pull request #23618: docs(docker): update README
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on code in PR #23618:
URL: https://github.com/apache/superset/pull/23618#discussion_r1162742382
##########
docker/README.md:
##########
@@ -37,6 +37,21 @@ intended for use with local development.
In order to override configuration settings locally, simply make a copy of [`./docker/pythonpath_dev/superset_config_local.example`](./pythonpath_dev/superset_config_local.example)
into `./docker/pythonpath_dev/superset_config_docker.py` (git ignored) and fill in your overrides.
+Alternatively, you can override configuration settings in `docker-compose.yml` by using [extension fields](https://docs.docker.com/compose/compose-file/11-extension/#using-extensions-as-fragments) like this:
+
+```yml
+x-superset-environment: &superset-environment
+ - SUPERSET_SECRET_KEY=<secret_key>
+```
+
+Then add `*superset-environment` to each `superset service` as follows:
+
+```yml
+services:
+ superset:
+ environment: *superset-environment
+```
+
Review Comment:
we are currently using docker/.env https://github.com/apache/superset/blob/master/docker/.env
no need to add to every service
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sebastianliebscher closed pull request #23618: docs(docker): update README
Posted by "sebastianliebscher (via GitHub)" <gi...@apache.org>.
sebastianliebscher closed pull request #23618: docs(docker): update README
URL: https://github.com/apache/superset/pull/23618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org