You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/01/08 13:54:25 UTC

[GitHub] flink pull request #5258: [FLINK-8383][mesos] Disable test-jar shading

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5258

    [FLINK-8383][mesos] Disable test-jar shading

    ## What is the purpose of the change
    
    This PR disables the shading of the flink-mesos test jar, which resolves the build-failure we currently see on master.
    
    Note that this is just a bandaid; I don't know why this fails in the first place.
    
    ## Verifying this change
    
    Check travis build.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8383

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5258.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5258
    
----
commit f0758ab883bd8dcaa5d0d5ee3f8b675523907236
Author: zentol <ch...@...>
Date:   2018-01-08T13:49:37Z

    [FLINK-8383][mesos] Disable test-jar shading

----


---

[GitHub] flink issue #5258: [FLINK-8383][mesos] Disable test-jar shading

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5258
  
    +1 to merge for now to fix the build.
    



---

[GitHub] flink issue #5258: [FLINK-8383][mesos] Disable test-jar shading

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5258
  
    merging.


---

[GitHub] flink pull request #5258: [FLINK-8383][mesos] Disable test-jar shading

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5258


---