[GitHub] AprliRainkun commented on a change in pull request #112: Load X509 cert on client creation

[GitBox <gi...@apache.org>]

AprliRainkun commented on a change in pull request #112: Load X509 cert on client creation
URL: https://github.com/apache/incubator-openwhisk-client-go/pull/112#discussion_r249302813
 
 

 ##########
 File path: whisk/client.go
 ##########
 @@ -176,17 +182,28 @@ func NewClient(httpClient *http.Client, config_input *Config) (*Client, error) {
 	c.Info = &InfoService{client: c}
 	c.Apis = &ApiService{client: c}
 
+	werr := c.LoadX509KeyPair()
+	if werr != nil {
+		return nil, werr
+	}
+
 	return c, nil
 }
 
 func (c *Client) LoadX509KeyPair() error {
+	var tlsModified bool
+
 	tlsConfig := &tls.Config{
 		InsecureSkipVerify: c.Config.Insecure,
 	}
+	// reasoned from: tlsModified = (c.config.Insecure != boolean default)
 
 Review comment:
   Sure, removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services