You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/10 01:54:25 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #6740: [AIRFLOW-6181] Add InProcessExecutor

kaxil commented on a change in pull request #6740: [AIRFLOW-6181] Add InProcessExecutor
URL: https://github.com/apache/airflow/pull/6740#discussion_r355808853
 
 

 ##########
 File path: airflow/models/taskinstance.py
 ##########
 @@ -885,6 +887,15 @@ def _run_raw_task(
                 context = self.get_template_context()
 
                 task_copy = copy.copy(task)
+
+                # Sensors in `poke` mode can block execution of DAGs when running
+                # with single process executor, thus we change the mode to`reschedule`
+                # to allow parallel task being scheduled and executed
+                if issubclass(type(task_copy), BaseSensorOperator) and \
 
 Review comment:
   Can we not simplify this with following:
   ```suggestion
                   if isintance(task_copy, BaseSensorOperator) and \
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services