You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Kris Sterckx <no...@github.com> on 2013/08/19 12:29:30 UTC
[jclouds] Pull request - Neutron/Nova (#118)
Sending a pull request for the following 2 things :
* Basic Neutron support (Network, Subnet and Port)
* Refactoring of network stitching for Nova to be more specific
You can merge this Pull Request by running:
git pull https://github.com/KrisSterckx/jclouds master
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/118
-- Commit Summary --
* Refactored network stitching for Nova to be more specific
* Basic Neutron support (Network, Subnet and Port)
-- File Changes --
M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/parse/ParseAccessTest.java (12)
M apis/openstack-keystone/src/test/resources/keystoneAuthResponse.json (12)
A apis/openstack-neutron/pom.xml (125)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/NeutronApi.java (75)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/NeutronApiMetadata.java (107)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/config/NeutronProperties.java (28)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/config/NeutronRestClientModule.java (88)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/AllocationPool.java (126)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/BulkNetwork.java (210)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/BulkPort.java (232)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/BulkSubnet.java (274)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/HostRoute.java (128)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/IP.java (124)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/Network.java (258)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/NetworkType.java (46)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/Port.java (235)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/Reference.java (129)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/ReferenceWithName.java (112)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/State.java (30)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/Subnet.java (261)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/extensions/README.txt (3)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/features/NetworkApi.java (160)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/features/PortApi.java (163)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/features/SubnetApi.java (162)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/handlers/NeutronErrorHandler.java (64)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/options/CreateNetworkBulkOptions.java (141)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/options/CreateNetworkOptions.java (244)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/options/CreatePortBulkOptions.java (138)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/options/CreatePortOptions.java (245)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/options/CreateSubnetBulkOptions.java (144)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/options/CreateSubnetOptions.java (261)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/options/UpdateNetworkOptions.java (132)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/options/UpdatePortOptions.java (219)
A apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/options/UpdateSubnetOptions.java (219)
A apis/openstack-neutron/src/main/resources/META-INF/services/org.jclouds.apis.ApiMetadata (1)
A apis/openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/NeutronApiMetadataTest.java (36)
A apis/openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/features/NetworkApiExpectTest.java (245)
A apis/openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/features/NetworkApiLiveTest.java (116)
A apis/openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/features/PortApiExpectTest.java (246)
A apis/openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/features/PortApiLiveTest.java (153)
A apis/openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/features/SubnetApiExpectTest.java (254)
A apis/openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/features/SubnetApiLiveTest.java (135)
A apis/openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/internal/BaseNeutronApiExpectTest.java (70)
A apis/openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/internal/BaseNeutronApiLiveTest.java (47)
A apis/openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/internal/BaseNeutronExpectTest.java (68)
A apis/openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/parse/ParseNetworkTest.java (55)
A apis/openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/parse/ParsePortTest.java (54)
A apis/openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/parse/ParseSubnetTest.java (53)
A apis/openstack-neutron/src/test/resources/list_networks.json (62)
A apis/openstack-neutron/src/test/resources/list_ports.json (86)
A apis/openstack-neutron/src/test/resources/list_subnets.json (98)
A apis/openstack-neutron/src/test/resources/network.json (7)
A apis/openstack-neutron/src/test/resources/port.json (7)
A apis/openstack-neutron/src/test/resources/subnet.json (8)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/NovaComputeServiceAdapter.java (34)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/options/NovaTemplateOptions.java (153)
A apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/domain/Network.java (131)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/options/CreateServerOptions.java (104)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/options/NovaTemplateOptionsTest.java (156)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/features/ServerApiExpectTest.java (68)
M apis/pom.xml (1)
A core/src/main/java/org/jclouds/util/Preconditions2.java (54)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/118.patch
https://github.com/jclouds/jclouds/pull/118.diff
Re: [jclouds] Pull request - Neutron/Nova (#118)
Posted by Everett Toews <no...@github.com>.
Closed #118.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/118
Re: [jclouds] Pull request - Neutron/Nova (#118)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #605](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/605/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/118#issuecomment-22865394
Re: [jclouds] Pull request - Neutron/Nova (#118)
Posted by Everett Toews <no...@github.com>.
Okay. I see that yours is the more complete implementation.
1. Make this PR for https://github.com/jclouds/jclouds-labs-openstack
The PR description should contain the link https://issues.apache.org/jira/browse/JCLOUDS-176
2. How have you been doing your live testing?
Have you been using DevStack?
Do you have a localrc that you could share in a gist?
What version of OpenStack are you testing against?
Please answer these questions over in the new PR.
Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/118#issuecomment-23287783
Re: [jclouds] Pull request - Neutron/Nova (#118)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #147](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/147/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/118#issuecomment-22865397
Re: [jclouds] Pull request - Neutron/Nova (#118)
Posted by Kris Sterckx <no...@github.com>.
Hi
I reviewed quickly and seems that this implementation is far from complete
(only list and get) while mine has full CRUD support.
I would like to ask to favour mine.
Thanks
Kris
On Aug 22, 2013 10:22 PM, "Everett Toews" <no...@github.com> wrote:
> Are you aware of the Neutron PR from @andtrub <https://github.com/andtrub>over at
> jclouds/jclouds-labs-openstack#15<https://github.com/jclouds/jclouds-labs-openstack/issues/15>?
>
> Naturally we can only have one implementation of OpenStack Neutron. Would
> you be willing to review Andrey's work over there and bring your
> implementations together?
>
> BTW, jclouds-labs-openstack would be the proper place for any new
> OpenStack API/provider related PR.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds/pull/118#issuecomment-23121500>
> .
>
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/118#issuecomment-23273233
Re: [jclouds] Pull request - Neutron/Nova (#118)
Posted by Everett Toews <no...@github.com>.
Are you aware of the Neutron PR from @andtrub over at https://github.com/jclouds/jclouds-labs-openstack/pull/15 ?
Naturally we can only have one implementation of OpenStack Neutron. Would you be willing to review Andrey's work over there and bring your implementations together?
BTW, jclouds-labs-openstack would be the proper place for any new OpenStack API/provider related PR.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/118#issuecomment-23121500
Re: [jclouds] Pull request - Neutron/Nova (#118)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #321](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/321/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/118#issuecomment-22865057