[GitHub] [spark] pan3793 commented on a diff in pull request #40774: [SPARK-41210][K8S] Port executor failure tracker from Spark on YARN to K8s

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #40774:
URL: https://github.com/apache/spark/pull/40774#discussion_r1166235707


##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala:
##########
@@ -889,9 +870,7 @@ private[spark] class ApplicationMaster(
 object ApplicationMaster extends Logging {
 
   // exit codes for different causes, no reason behind the values
-  private val EXIT_SUCCESS = 0
   private val EXIT_UNCAUGHT_EXCEPTION = 10
-  private val EXIT_MAX_EXECUTOR_FAILURES = 11

Review Comment:
   Seems impossible
   ```
   [error] /Users/chengpan/Projects/apache-spark/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala:873:48: recursive value EXIT_SUCCESS needs type
   [error]   private val EXIT_SUCCESS = ApplicationMaster.EXIT_SUCCESS
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org