[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #2044: fix: hugegraph script error

[GitBox <gi...@apache.org>]

imbajin commented on code in PR #2044:
URL: https://github.com/apache/incubator-hugegraph/pull/2044#discussion_r1038904320


##########
hugegraph-dist/src/assembly/static/bin/hugegraph:
##########
@@ -23,8 +23,8 @@
 INSTALL_DIR=
 SERVER_PORT=
 
-${INSTALL_DIR:?"Please open the script then set variable 'INSTALL_DIR' manually"}
-${SERVER_PORT:?"Please open the script then set variable 'SERVER_PORT' manually"}
+INSTALL_DIR=${INSTALL_DIR:?"Please open the script then set variable 'INSTALL_DIR' manually"}
+SERVER_PORT=${SERVER_PORT:?"Please open the script then set variable 'SERVER_PORT' manually"}

Review Comment:
   nice catch，I'll test it in ubuntu21 later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org