You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mark Miller (JIRA)" <ji...@apache.org> on 2016/11/19 02:40:58 UTC
[jira] [Comment Edited] (SOLR-9712) Saner default for
maxWarmingSearchers
[ https://issues.apache.org/jira/browse/SOLR-9712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15677862#comment-15677862 ]
Mark Miller edited comment on SOLR-9712 at 11/19/16 2:40 AM:
-------------------------------------------------------------
bq. That code just logs an InterruptedException, but perhaps we should throw an exception in that case
I almost would prefer not letting this get interrupted, it's a nasty path to test and I worry about everything going smoothly in all cases. On the other hand, if this code is interrupted, there is a good chance you are going to run into closed channel issues anyway.
was (Author: markrmiller@gmail.com):
I almost would prefer not letting this get interrupted, it's a nasty path to test and I worry about everything going smoothly in all cases. On the other hand, if this code is interrupted, there is a good chance you are going to run into closed channel issues anyway.
> Saner default for maxWarmingSearchers
> -------------------------------------
>
> Key: SOLR-9712
> URL: https://issues.apache.org/jira/browse/SOLR-9712
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: search
> Reporter: Shalin Shekhar Mangar
> Fix For: master (7.0), 6.4
>
> Attachments: SOLR-9712.patch
>
>
> As noted in SOLR-9710, the default for maxWarmingSearchers is Integer.MAX_VALUE which is just crazy. Let's have a saner default. Today we log a performance warning when the number of on deck searchers goes over 1. What if we had the default as 1 that expert users can increase if needed?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org