[GitHub] metron pull request #849: METRON-1334 Add C++11 Compliance Check to 'platfor...

[ottobackwards <gi...@git.apache.org>]

Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/849#discussion_r153322627
  
    --- Diff: metron-deployment/scripts/platform-info.sh ---
    @@ -73,6 +73,30 @@ echo "--"
     echo "npm"
     npm --version
     
    +# C++ compiler
    +echo "--"
    +echo "g++"
    +g++ --version
    +
    +# C++11 compliant compiler
    +echo "--"
    +OBJFILE=/tmp/test
    +CPPFILE=/tmp/test.cpp
    +cat > $CPPFILE <<- EOM
    +#include <iostream>
    +using namespace std;
    +int main() {
    +    cout << "Hello World!" << endl;
    +    return 0;
    +}
    +EOM
    +g++ -std=c++11 $CPPFILE -o $OBJFILE
    +if [ $? -eq 0 ]; then
    +    echo "Compiler is C++11 compliant"
    +else
    +    echo "Warning: Compiler is NOT C++11 compliant"
    +fi
    +rm -f $CPPFILE $OBJFILE
     
    --- End diff --
    
    A standard way in the language is to check for the value of __cplusplus
    
    201402L  is CPP 14
    201103L is CPP 11
    
    I don't have a preference, just throwing this out there.


---