You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dtenedor (via GitHub)" <gi...@apache.org> on 2024/01/26 21:11:54 UTC

[PR] [SPARK-46879][SQL] Run optimizer on REPLACE TABLE column defaults [spark]

dtenedor opened a new pull request, #44904:
URL: https://github.com/apache/spark/pull/44904

   ### What changes were proposed in this pull request?
   
   This PR updates Catalyst to run the optimizer over `REPLACE TABLE` column default expressions.
   
   This is similar to and builds on https://github.com/apache/spark/pull/44876, which added this support to `CREATE TABLE` commands
   
   ### Why are the changes needed?
   
   This helps speed up future commands that assign default values within the table.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   The functionality is covered by existing tests.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-46879][SQL] Run optimizer on REPLACE TABLE column defaults [spark]

Posted by "dtenedor (via GitHub)" <gi...@apache.org>.
dtenedor commented on PR #44904:
URL: https://github.com/apache/spark/pull/44904#issuecomment-1915388811

   It looks like @cloud-fan created a PR [1] which implements the functionality of this one, so I will close this PR in favor of his.
   
   [1] https://github.com/apache/spark/pull/44935


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-46879][SQL] Run optimizer on REPLACE TABLE column defaults [spark]

Posted by "dtenedor (via GitHub)" <gi...@apache.org>.
dtenedor closed pull request #44904: [SPARK-46879][SQL] Run optimizer on REPLACE TABLE column defaults
URL: https://github.com/apache/spark/pull/44904


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org