You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2012/10/17 20:08:14 UTC

Review Request: Adding run number in executor struct in slave

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7638/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Ben Mahler.


Description
-------

This will be useful, both for slave restart and files


Diffs
-----

  src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177 

Diff: https://reviews.apache.org/r/7638/diff/


Testing
-------

make check (in progress)


Thanks,

Vinod Kone

Re: Review Request: Adding run number in executor struct in slave

Posted by Vinod Kone <vi...@gmail.com>.

> On Oct. 24, 2012, 6:36 a.m., Benjamin Hindman wrote:
> > Can this be discarded now?

yes


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7638/#review12708
-----------------------------------------------------------


On Oct. 17, 2012, 6:22 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7638/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2012, 6:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> This will be useful, both for slave restart and files
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177 
> 
> Diff: https://reviews.apache.org/r/7638/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request: Adding run number in executor struct in slave

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7638/#review12708
-----------------------------------------------------------


Can this be discarded now?

- Benjamin Hindman


On Oct. 17, 2012, 6:22 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7638/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2012, 6:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> This will be useful, both for slave restart and files
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177 
> 
> Diff: https://reviews.apache.org/r/7638/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request: Adding run number in executor struct in slave

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7638/#review12528
-----------------------------------------------------------



src/slave/slave.hpp
<https://reviews.apache.org/r/7638/#comment26691>

    I'm not sure how I feel about this, would be nice to see a clear check on the directory format.


- Ben Mahler


On Oct. 17, 2012, 6:22 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7638/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2012, 6:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> This will be useful, both for slave restart and files
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177 
> 
> Diff: https://reviews.apache.org/r/7638/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request: Adding run number in executor struct in slave

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7638/
-----------------------------------------------------------

(Updated Oct. 17, 2012, 6:22 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

tests passed


Description
-------

This will be useful, both for slave restart and files


Diffs
-----

  src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177 

Diff: https://reviews.apache.org/r/7638/diff/


Testing (updated)
-------

make check


Thanks,

Vinod Kone

Re: Review Request: Adding run number in executor struct in slave

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7638/
-----------------------------------------------------------

(Updated Oct. 17, 2012, 6:14 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

less ugly


Description
-------

This will be useful, both for slave restart and files


Diffs (updated)
-----

  src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177 

Diff: https://reviews.apache.org/r/7638/diff/


Testing
-------

make check (in progress)


Thanks,

Vinod Kone