[PR] Improve readability of Keycloak container cleanup [polaris]

["bowsii (via GitHub)" <gi...@apache.org>]

bowsii opened a new pull request, #4743:
URL: https://github.com/apache/polaris/pull/4743

   ## Summary
   
   Fixes #4742
   
   Replace an empty try-with-resources block in `KeycloakLifecycleManager.stop()` with an explicit `keycloak.stop()` call.
   
   The previous implementation relied on an empty try-with-resources block to trigger automatic cleanup through `AutoCloseable.close()`. While functionally correct, the intent was not immediately obvious because the resource was never referenced within the block.
   
   This change preserves the existing behavior while making the resource cleanup logic clearer and more consistent with other lifecycle managers in the codebase.
   
   ## Changes
   
   * Replace empty try-with-resources cleanup pattern with an explicit `keycloak.stop()` call.
   * Retain the existing `finally` block to ensure the field is cleared.
   * No functional behavior changes.
   
   ## Test Plan
   
   * [x] `./gradlew :polaris-runtime-test-common:compileJava`
   
   ## Impact
   
   * Readability improvement only.
   * No behavioral changes.
   * No API changes.
   
   
   ## Checklist
   - [ ] 🛡️ Don't disclose security issues! (contact security@apache.org)
   - [ ] 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
   - [ ] 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
   - [ ] 💡 Added comments for complex logic
   - [ ] 🧾 Updated `CHANGELOG.md` (if needed)
   - [ ] 📚 Updated documentation in `site/content/in-dev/unreleased` (if needed)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improve readability of Keycloak container cleanup [polaris]

["adutra (via GitHub)" <gi...@apache.org>]

adutra merged PR #4743:
URL: https://github.com/apache/polaris/pull/4743


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org