You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/02 00:59:27 UTC
Review Request 61361: Replaced `MESOS_3RDPARTY_*` with
`CMAKE_CURRENT_*_DIR`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61361/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
This variable was superfluous, and set as a side effect of
`Mesos3rdpartyConfigure.cmake`.
Diffs
-----
3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063
Diff: https://reviews.apache.org/r/61361/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 61361: Replaced `MESOS_3RDPARTY_*` with
`CMAKE_CURRENT_*_DIR`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61361/#review184452
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Aug. 7, 2017, 1:58 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61361/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2017, 1:58 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This variable was superfluous, and set as a side effect of
> `Mesos3rdpartyConfigure.cmake`.
>
> Review: https://reviews.apache.org/r/61361
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063
> 3rdparty/cmake/Mesos3rdpartyConfigure.cmake fa1202a5a6a7d37d94b52e2142528febd1b23a10
>
>
> Diff: https://reviews.apache.org/r/61361/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61361: Replaced `MESOS_3RDPARTY_*` with
`CMAKE_CURRENT_*_DIR`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61361/
-----------------------------------------------------------
(Updated Aug. 7, 2017, 1:58 p.m.)
Review request for mesos.
Repository: mesos
Description
-------
This variable was superfluous, and set as a side effect of
`Mesos3rdpartyConfigure.cmake`.
Review: https://reviews.apache.org/r/61361
Diffs (updated)
-----
3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063
3rdparty/cmake/Mesos3rdpartyConfigure.cmake fa1202a5a6a7d37d94b52e2142528febd1b23a10
Diff: https://reviews.apache.org/r/61361/diff/3/
Changes: https://reviews.apache.org/r/61361/diff/2-3/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 61361: Replaced `MESOS_3RDPARTY_*` with
`CMAKE_CURRENT_*_DIR`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61361/
-----------------------------------------------------------
(Updated Aug. 7, 2017, 1:05 p.m.)
Review request for mesos.
Changes
-------
Missed libev.
Repository: mesos
Description (updated)
-------
This variable was superfluous, and set as a side effect of
`Mesos3rdpartyConfigure.cmake`.
Review: https://reviews.apache.org/r/61361
Diffs (updated)
-----
3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063
Diff: https://reviews.apache.org/r/61361/diff/2/
Changes: https://reviews.apache.org/r/61361/diff/1-2/
Testing
-------
Thanks,
Andrew Schwartzmeyer