You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Sven Meier (Jira)" <ji...@apache.org> on 2020/10/07 08:28:00 UTC

[jira] [Commented] (WICKET-6839) Component visible-in-hierarchy cache not used but cleared

    [ https://issues.apache.org/jira/browse/WICKET-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209383#comment-17209383 ] 

Sven Meier commented on WICKET-6839:
------------------------------------

Seems checking of that flag has been missing from the start:

https://github.com/apache/wicket/commit/573f71b97d9b2085d2333e905e021546227ff60c

> Component visible-in-hierarchy cache not used but cleared
> ---------------------------------------------------------
>
>                 Key: WICKET-6839
>                 URL: https://issues.apache.org/jira/browse/WICKET-6839
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 9.0.0, 8.9.0
>            Reporter: Tobias Haupt
>            Priority: Major
>
> When the visibility of a component is changed via setVisible(), the Component and especially the MarkupContainer clears a cache flag (RFLAG_*VISIBLE*_IN_HIERARCHY_SET) on all contained components.
> Unlike the flag for isEnabledInHiearchy (RFLAG_*ENABLED*_IN_HIERARCHY_SET), the flag for visibility seems not to be updated and used in isVisibleInHiearchy.
> Resolution: either use the cache or avoid the (expensive) clearance for all children.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)