You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/12 14:04:19 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #5753: [AIRFLOW-4686] Make dags Pylint compatible

mik-laj commented on a change in pull request #5753: [AIRFLOW-4686] Make dags Pylint compatible
URL: https://github.com/apache/airflow/pull/5753#discussion_r312941051
 
 

 ##########
 File path: airflow/contrib/example_dags/example_emr_job_flow_manual_steps.py
 ##########
 @@ -16,7 +16,14 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+"""
+This is an example dag for a AWS EMR Pipeline.
 
+Starting by creating a cluster,
 
 Review comment:
   Personally, I don't like lists in file headers. It is very difficult to keep them up to date. It also seems to me that this sentence has formatting problems. If this is a list then each point should start with a star character.  If this is not a list then the sentence should be on one line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services