You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/01/20 10:16:34 UTC
[GitHub] [kylin] codecov-io commented on issue #1076: Prevent uncontrolled
data used in path expression
codecov-io commented on issue #1076: Prevent uncontrolled data used in path expression
URL: https://github.com/apache/kylin/pull/1076#issuecomment-576204464
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1076?src=pr&el=h1) Report
> Merging [#1076](https://codecov.io/gh/apache/kylin/pull/1076?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/43b248d807cea23c648b8cc730d94901f3635d42?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `40%`.
[](https://codecov.io/gh/apache/kylin/pull/1076?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1076 +/- ##
============================================
- Coverage 25.07% 25.05% -0.02%
+ Complexity 6223 6221 -2
============================================
Files 1438 1438
Lines 87730 87734 +4
Branches 12257 12257
============================================
- Hits 21995 21981 -14
- Misses 63588 63601 +13
- Partials 2147 2152 +5
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1076?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/kylin/job/execution/ExecutableManager.java](https://codecov.io/gh/apache/kylin/pull/1076/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vRXhlY3V0YWJsZU1hbmFnZXIuamF2YQ==) | `32.44% <33.33%> (ø)` | `35 <1> (ø)` | :arrow_down: |
| [...ylin/metadata/badquery/BadQueryHistoryManager.java](https://codecov.io/gh/apache/kylin/pull/1076/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvYmFkcXVlcnkvQmFkUXVlcnlIaXN0b3J5TWFuYWdlci5qYXZh) | `76.66% <50%> (-2.65%)` | `9 <1> (ø)` | |
| [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1076/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1076/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `52.27% <0%> (-3.41%)` | `8% <0%> (ø)` | |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1076/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1076/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-1.83%)` | `7% <0%> (ø)` | |
| [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/1076/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1076?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1076?src=pr&el=footer). Last update [43b248d...839bd04](https://codecov.io/gh/apache/kylin/pull/1076?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services