You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2017/02/22 17:32:32 UTC
[GitHub] brooklyn-server pull request #568: Fix application start problems
GitHub user ahgittin opened a pull request:
https://github.com/apache/brooklyn-server/pull/568
Fix application start problems
A bug was introduced in https://github.com/apache/brooklyn-server/pull/393 where if there are errors in a custom `Application.doStart(...)`, the `start` effector fails but the application does not.
This corrects that using a special exception to allow children problems to pass through.
/cc @sjcorbett @neykov
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/brooklyn-server fix-application-start-problems
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/568.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #568
----
commit 1bbe475818e5912f28009ff221b9fd75ce1ff4e2
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2017-02-22T17:22:30Z
add test illustrating the failure in dacf18b831e1e5e1383d662a873643a3c3cabac6
commit 4e0be7f696325adad0389aac3b756c043cb268d9
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2017-02-22T17:23:02Z
fix the problem in the previous test
where failure in custom start behaviour in applications does not cause an app to go on fire
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #568: Fix application start problems
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/568
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---