You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/01/15 07:31:58 UTC

[GitHub] [netbeans] lkishalmi opened a new pull request #1873: [NETBEANS-3428] Remove experimental from FlatLafDark

lkishalmi opened a new pull request #1873: [NETBEANS-3428] Remove experimental from FlatLafDark
URL: https://github.com/apache/netbeans/pull/1873
 
 
   Also added the preferred color profile for standard supported LaF-s, so switching back some Dark to regular light LaF offers you changing the editor coloring back to default NetBeans as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] lkishalmi merged pull request #1873: [NETBEANS-3428] Remove experimental from FlatLafDark

Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #1873: [NETBEANS-3428] Remove experimental from FlatLafDark
URL: https://github.com/apache/netbeans/pull/1873
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] eirikbakke commented on a change in pull request #1873: [NETBEANS-3428] Remove experimental from FlatLafDark

Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1873: [NETBEANS-3428] Remove experimental from FlatLafDark
URL: https://github.com/apache/netbeans/pull/1873#discussion_r367208178
 
 

 ##########
 File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/Installer.java
 ##########
 @@ -26,16 +26,14 @@
 
 @NbBundle.Messages({
     "LBL_FLATLAF_LIGHT=FlatLaf Light (experimental)",
 
 Review comment:
   Sure.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] lkishalmi commented on a change in pull request #1873: [NETBEANS-3428] Remove experimental from FlatLafDark

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #1873: [NETBEANS-3428] Remove experimental from FlatLafDark
URL: https://github.com/apache/netbeans/pull/1873#discussion_r366923297
 
 

 ##########
 File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/Installer.java
 ##########
 @@ -26,16 +26,14 @@
 
 @NbBundle.Messages({
     "LBL_FLATLAF_LIGHT=FlatLaf Light (experimental)",
 
 Review comment:
   Well, I think it was tested less than the dark one and probably needs a fitting FlatLaf Light color theme, however thinking it over it is not worse than the Dark Nimbus or Dark Metal, so let's remove the experimental from there as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] eirikbakke commented on a change in pull request #1873: [NETBEANS-3428] Remove experimental from FlatLafDark

Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1873: [NETBEANS-3428] Remove experimental from FlatLafDark
URL: https://github.com/apache/netbeans/pull/1873#discussion_r366878368
 
 

 ##########
 File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/Installer.java
 ##########
 @@ -26,16 +26,14 @@
 
 @NbBundle.Messages({
     "LBL_FLATLAF_LIGHT=FlatLaf Light (experimental)",
 
 Review comment:
   Is the light version still experimental?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists