You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by po...@apache.org on 2022/10/28 15:51:43 UTC

[airflow] branch main updated: Limit when git clone tests is run (#27349)

This is an automated email from the ASF dual-hosted git repository.

potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/main by this push:
     new afa5ce42f1 Limit when git clone tests is run (#27349)
afa5ce42f1 is described below

commit afa5ce42f196ac8d346fc860920f49d8cdaa6077
Author: Jarek Potiuk <ja...@potiuk.com>
AuthorDate: Fri Oct 28 17:51:12 2022 +0200

    Limit when git clone tests is run (#27349)
    
    The "Test git clone on Windows" job is always run on GitHub
    Public runners (we have no self-hosted windows runners). This
    means that when the "Public runner queue" is full, the PRs from
    maintainers that are using self-hosted-runners might not
    complete even if all the self-hosted runners job complete.
    
    This is not a big issue if that one gets broken, it has no
    impact on other tests, so this is fine to only leave this one
    running for "Public" PRs - i.e. when non-maintainers make
    PRs from their forks or when "use public runners" label is set
    on maintainer's PR.
    
    The job is small and fast so it introduces almost no overhead
    for "Public Runner's PRs" - while there are public runners
    available, it takes literally < 20s to complete. But for
    self-hosted runners it might introduce unnecessary "hold" on
    complete status.
    
    This should be enough to detect any problems - we will see it
    failing in user's PRs and will be able to fix it, while it will
    not block PRs of commiters and "canary" builds from completing
    when the Public Job Queue gets busy.
---
 .github/workflows/ci.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 1370b67d8f..6d4e91ad84 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -630,6 +630,7 @@ ${{ hashFiles('.pre-commit-config.yaml') }}"
         with:
           fetch-depth: 2
           persist-credentials: false
+    if: needs.build-info.outputs.runs-on != 'self-hosted'
 
   wait-for-ci-images:
     timeout-minutes: 120