You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Jonathon Wong (JIRA)" <ji...@apache.org> on 2007/01/13 05:13:27 UTC
[jira] Created: (OFBIZ-621) "Add to cart" button still active even
though last feature is not selected
"Add to cart" button still active even though last feature is not selected
--------------------------------------------------------------------------
Key: OFBIZ-621
URL: https://issues.apache.org/jira/browse/OFBIZ-621
Project: Apache OFBiz (The Open for Business Project)
Issue Type: Bug
Components: ecommerce
Affects Versions: SVN trunk
Reporter: Jonathon Wong
Fix For: SVN trunk
Bug in Order module webapp/ordermgr/entry/catalog/productdetail.ftl . Try buying a WG-9943, select black, then 3-wheel, then size. You'll see that the text box left of "Add to cart" is still enabled.
I've attached a tiny patch.
In the patch, I've also added a display of "Product ID: ---" right below the features selection. Upon selecting the last feature, the chosen variant's product Id will appear. You can cut out this part if it doesn't fit into OFBiz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (OFBIZ-621) "Add to cart" button still active even
though last feature is not selected
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-621.
---------------------------------
Resolution: Fixed
Assignee: Jacques Le Roux
> "Add to cart" button still active even though last feature is not selected
> --------------------------------------------------------------------------
>
> Key: OFBIZ-621
> URL: https://issues.apache.org/jira/browse/OFBIZ-621
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: productdetail.ftl.patch
>
>
> Bug in Order module webapp/ordermgr/entry/catalog/productdetail.ftl . Try buying a WG-9943, select black, then 3-wheel, then size. You'll see that the text box left of "Add to cart" is still enabled.
> I've attached a tiny patch.
> In the patch, I've also added a display of "Product ID: ---" right below the features selection. Upon selecting the last feature, the chosen variant's product Id will appear. You can cut out this part if it doesn't fit into OFBiz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-621) "Add to cart" button still active
even though last feature is not selected
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464461 ]
Jacques Le Roux commented on OFBIZ-621:
---------------------------------------
Finally I applied the pacth with some modifications :
1. The id appears only when complete choice is done (so "Product ID: ---" is never seen)
2. In bold and same font than product Id above
3. Kept only the id itself (supressed "Product ID:")
Your patch is in OFBiz revision: 495898
Thanks
> "Add to cart" button still active even though last feature is not selected
> --------------------------------------------------------------------------
>
> Key: OFBIZ-621
> URL: https://issues.apache.org/jira/browse/OFBIZ-621
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Fix For: SVN trunk
>
> Attachments: productdetail.ftl.patch
>
>
> Bug in Order module webapp/ordermgr/entry/catalog/productdetail.ftl . Try buying a WG-9943, select black, then 3-wheel, then size. You'll see that the text box left of "Add to cart" is still enabled.
> I've attached a tiny patch.
> In the patch, I've also added a display of "Product ID: ---" right below the features selection. Upon selecting the last feature, the chosen variant's product Id will appear. You can cut out this part if it doesn't fit into OFBiz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-621) "Add to cart" button still active even
though last feature is not selected
Posted by "Jonathon Wong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathon Wong updated OFBIZ-621:
--------------------------------
Attachment: productdetail.ftl.patch
> "Add to cart" button still active even though last feature is not selected
> --------------------------------------------------------------------------
>
> Key: OFBIZ-621
> URL: https://issues.apache.org/jira/browse/OFBIZ-621
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Fix For: SVN trunk
>
> Attachments: productdetail.ftl.patch
>
>
> Bug in Order module webapp/ordermgr/entry/catalog/productdetail.ftl . Try buying a WG-9943, select black, then 3-wheel, then size. You'll see that the text box left of "Add to cart" is still enabled.
> I've attached a tiny patch.
> In the patch, I've also added a display of "Product ID: ---" right below the features selection. Upon selecting the last feature, the chosen variant's product Id will appear. You can cut out this part if it doesn't fit into OFBiz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-621) "Add to cart" button still active
even though last feature is not selected
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464458 ]
Jacques Le Roux commented on OFBIZ-621:
---------------------------------------
Ha yes, understood : you re-select size in the drop-down after of course. Yes you are right : very annoying, your patch resolves the problem. I will apply it soon
> "Add to cart" button still active even though last feature is not selected
> --------------------------------------------------------------------------
>
> Key: OFBIZ-621
> URL: https://issues.apache.org/jira/browse/OFBIZ-621
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Fix For: SVN trunk
>
> Attachments: productdetail.ftl.patch
>
>
> Bug in Order module webapp/ordermgr/entry/catalog/productdetail.ftl . Try buying a WG-9943, select black, then 3-wheel, then size. You'll see that the text box left of "Add to cart" is still enabled.
> I've attached a tiny patch.
> In the patch, I've also added a display of "Product ID: ---" right below the features selection. Upon selecting the last feature, the chosen variant's product Id will appear. You can cut out this part if it doesn't fit into OFBiz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-621) "Add to cart" button still active
even though last feature is not selected
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464457 ]
Jacques Le Roux commented on OFBIZ-621:
---------------------------------------
Jonathon,
I can't see all here.
1. You said "Try buying a WG-9943, select black, then 3-wheel, then size.". Well 3-wheel is a size here
2. You said "You'll see that the text box left of "Add to cart" is still enabled. ". Well of course, I may want to buy more than one unit, or do I misunderstand something here ?
3. Though a very minor enhancement, the display of "Product ID: ---" sounds fine to me. Nevertheless If I apply it I propose to use the same font and bold as for virtual product code.
Thanks
> "Add to cart" button still active even though last feature is not selected
> --------------------------------------------------------------------------
>
> Key: OFBIZ-621
> URL: https://issues.apache.org/jira/browse/OFBIZ-621
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Fix For: SVN trunk
>
> Attachments: productdetail.ftl.patch
>
>
> Bug in Order module webapp/ordermgr/entry/catalog/productdetail.ftl . Try buying a WG-9943, select black, then 3-wheel, then size. You'll see that the text box left of "Add to cart" is still enabled.
> I've attached a tiny patch.
> In the patch, I've also added a display of "Product ID: ---" right below the features selection. Upon selecting the last feature, the chosen variant's product Id will appear. You can cut out this part if it doesn't fit into OFBiz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira