You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@couchdb.apache.org by be...@apache.org on 2015/09/08 18:47:13 UTC
fauxton commit: updated refs/heads/master to 8219b17
Repository: couchdb-fauxton
Updated Branches:
refs/heads/master 1c8d86e75 -> 8219b17e0
Increase timeout for NW tests
The max timeout time for several of the NW custom commands was
set to 10 seconds. Recently NW tests have been failing a good deal
more (esp on the dash) and all appear to be due to timeouts.
This PR changes it to use the default timeout time (30 seconds). I
think this is wise in any event, since ANY effort to increase the
robustness of the tests is needed. Plus it won't slow anything
down - just any test that's legitimately failing.
Project: http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/commit/8219b17e
Tree: http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/tree/8219b17e
Diff: http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/diff/8219b17e
Branch: refs/heads/master
Commit: 8219b17e01ce12e9dbf1e7bc18112c9d68c54f9f
Parents: 1c8d86e
Author: Ben Keen <be...@gmail.com>
Authored: Mon Aug 31 14:52:23 2015 -0700
Committer: Ben Keen <be...@gmail.com>
Committed: Tue Sep 8 09:49:17 2015 -0700
----------------------------------------------------------------------
.../custom-commands/checkForDatabaseCreated.js | 2 +-
.../custom-commands/checkForDatabaseDeleted.js | 2 +-
.../custom-commands/checkForDocumentCreated.js | 2 +-
.../custom-commands/checkForStringNotPresent.js | 2 +-
.../nightwatch_tests/custom-commands/checkForStringPresent.js | 2 +-
test/nightwatch_tests/custom-commands/clickWhenVisible.js | 4 +++-
test/nightwatch_tests/custom-commands/closeNotification.js | 7 ++++---
7 files changed, 12 insertions(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/blob/8219b17e/test/nightwatch_tests/custom-commands/checkForDatabaseCreated.js
----------------------------------------------------------------------
diff --git a/test/nightwatch_tests/custom-commands/checkForDatabaseCreated.js b/test/nightwatch_tests/custom-commands/checkForDatabaseCreated.js
index 7889f2e..76c3ec9 100644
--- a/test/nightwatch_tests/custom-commands/checkForDatabaseCreated.js
+++ b/test/nightwatch_tests/custom-commands/checkForDatabaseCreated.js
@@ -26,7 +26,7 @@ CheckForDatabaseCreated.prototype.command = function (databaseName, timeout) {
var couchUrl = helpers.test_settings.db_url;
if (!timeout) {
- timeout = 10000;
+ timeout = helpers.maxWaitTime;
}
var timeOutId = setTimeout(function () {
http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/blob/8219b17e/test/nightwatch_tests/custom-commands/checkForDatabaseDeleted.js
----------------------------------------------------------------------
diff --git a/test/nightwatch_tests/custom-commands/checkForDatabaseDeleted.js b/test/nightwatch_tests/custom-commands/checkForDatabaseDeleted.js
index 2888ea6..e6931cc 100644
--- a/test/nightwatch_tests/custom-commands/checkForDatabaseDeleted.js
+++ b/test/nightwatch_tests/custom-commands/checkForDatabaseDeleted.js
@@ -26,7 +26,7 @@ CheckForDatabaseDeleted.prototype.command = function (databaseName, timeout) {
var couchUrl = helpers.test_settings.db_url;
if (!timeout) {
- timeout = 10000;
+ timeout = helpers.maxWaitTime;
}
var timeOutId = setTimeout(function () {
http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/blob/8219b17e/test/nightwatch_tests/custom-commands/checkForDocumentCreated.js
----------------------------------------------------------------------
diff --git a/test/nightwatch_tests/custom-commands/checkForDocumentCreated.js b/test/nightwatch_tests/custom-commands/checkForDocumentCreated.js
index 2468883..3d3b16a 100644
--- a/test/nightwatch_tests/custom-commands/checkForDocumentCreated.js
+++ b/test/nightwatch_tests/custom-commands/checkForDocumentCreated.js
@@ -27,7 +27,7 @@ CheckForDocumentCreated.prototype.command = function (doc, timeout) {
db = helpers.testDatabaseName;
if (!timeout) {
- timeout = 10000;
+ timeout = helpers.maxWaitTime;
}
var timeOutId = setTimeout(function () {
http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/blob/8219b17e/test/nightwatch_tests/custom-commands/checkForStringNotPresent.js
----------------------------------------------------------------------
diff --git a/test/nightwatch_tests/custom-commands/checkForStringNotPresent.js b/test/nightwatch_tests/custom-commands/checkForStringNotPresent.js
index 5712173..85b581b 100644
--- a/test/nightwatch_tests/custom-commands/checkForStringNotPresent.js
+++ b/test/nightwatch_tests/custom-commands/checkForStringNotPresent.js
@@ -27,7 +27,7 @@ CheckForStringNotPresent.prototype.command = function (path, string, timeout) {
db = helpers.testDatabaseName;
if (!timeout) {
- timeout = 10000;
+ timeout = helpers.maxWaitTime;
}
var timeOutId = setTimeout(function () {
http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/blob/8219b17e/test/nightwatch_tests/custom-commands/checkForStringPresent.js
----------------------------------------------------------------------
diff --git a/test/nightwatch_tests/custom-commands/checkForStringPresent.js b/test/nightwatch_tests/custom-commands/checkForStringPresent.js
index f367f8b..21855d8 100644
--- a/test/nightwatch_tests/custom-commands/checkForStringPresent.js
+++ b/test/nightwatch_tests/custom-commands/checkForStringPresent.js
@@ -27,7 +27,7 @@ CheckForStringPresent.prototype.command = function (path, string, timeout) {
db = helpers.testDatabaseName;
if (!timeout) {
- timeout = 10000;
+ timeout = helpers.maxWaitTime;
}
var timeOutId = setTimeout(function () {
http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/blob/8219b17e/test/nightwatch_tests/custom-commands/clickWhenVisible.js
----------------------------------------------------------------------
diff --git a/test/nightwatch_tests/custom-commands/clickWhenVisible.js b/test/nightwatch_tests/custom-commands/clickWhenVisible.js
index c56baf2..183ac51 100644
--- a/test/nightwatch_tests/custom-commands/clickWhenVisible.js
+++ b/test/nightwatch_tests/custom-commands/clickWhenVisible.js
@@ -10,10 +10,12 @@
// License for the specific language governing permissions and limitations under
// the License.
+var helpers = require('../helpers/helpers.js');
+
exports.command = function (element, waitTime) {
if (waitTime === undefined) {
- waitTime = 10000;
+ waitTime = helpers.maxWaitTime;
}
this
http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/blob/8219b17e/test/nightwatch_tests/custom-commands/closeNotification.js
----------------------------------------------------------------------
diff --git a/test/nightwatch_tests/custom-commands/closeNotification.js b/test/nightwatch_tests/custom-commands/closeNotification.js
index 0d70fb4..04120bc 100644
--- a/test/nightwatch_tests/custom-commands/closeNotification.js
+++ b/test/nightwatch_tests/custom-commands/closeNotification.js
@@ -10,13 +10,14 @@
// License for the specific language governing permissions and limitations under
// the License.
+var helpers = require('../helpers/helpers.js');
+
exports.command = function () {
- var waitTime = 8000,
- client = this,
+ var client = this,
dismissSelector = '#global-notifications .js-dismiss';
client
- .waitForElementPresent(dismissSelector, waitTime, false)
+ .waitForElementPresent(dismissSelector, helpers.maxWaitTime, false)
.click(dismissSelector);
return this;