You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/02/18 14:12:53 UTC

[GitHub] [fineract] ptuomola commented on pull request #1597: Add condition to start TLS (FINERACT-1070)

ptuomola commented on pull request #1597:
URL: https://github.com/apache/fineract/pull/1597#issuecomment-781371198


   Hi - instead of excluding this from the check, you really should look to exclude the duplicate inclusion of the same dependency. It only makes sense to remove it from the check if there is no other way to avoid it - eg if two different jars, which are both required, contain the same class. But that's not the case here, so excluding one of the dependencies would be the right way forward IMHO. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org