You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/12/28 17:22:48 UTC
[GitHub] [hudi] jonvex opened a new pull request, #7576: attempt at ssl implementation
jonvex opened a new pull request, #7576:
URL: https://github.com/apache/hudi/pull/7576
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1401406841
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1402359256
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022",
"triggerID" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"triggerType" : "PUSH"
}, {
"hash" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14069",
"triggerID" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"triggerType" : "PUSH"
}, {
"hash" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14071",
"triggerID" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2c025ed416ea8607b2e6dcc116415f114f87b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14368",
"triggerID" : "f7b2c025ed416ea8607b2e6dcc116415f114f87b",
"triggerType" : "PUSH"
}, {
"hash" : "777e992653f094345bcadb5d0ad2125663f5340c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14596",
"triggerID" : "777e992653f094345bcadb5d0ad2125663f5340c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7b2c025ed416ea8607b2e6dcc116415f114f87b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14368)
* 777e992653f094345bcadb5d0ad2125663f5340c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14596)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7576: attempt at ssl implementation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1369140678
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022",
"triggerID" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"triggerType" : "PUSH"
}, {
"hash" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14069",
"triggerID" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f665a724e2450d7c27f6e3d44bb443404f114036 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022)
* 8cacccb9c7f7f753790bab885482b504bcc7919b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14069)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a diff in pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope commented on code in PR #7576:
URL: https://github.com/apache/hudi/pull/7576#discussion_r1083674703
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/SchemaRegistryProvider.java:
##########
@@ -94,6 +121,33 @@ protected InputStream getStream(HttpURLConnection connection) throws IOException
public SchemaRegistryProvider(TypedProperties props, JavaSparkContext jssc) {
super(props, jssc);
DataSourceUtils.checkRequiredProperties(props, Collections.singletonList(Config.SRC_SCHEMA_REGISTRY_URL_PROP));
+ if (config.containsKey(Config.SSL_KEYSTORE_LOCATION_PROP)
+ || config.containsKey(Config.SSL_TRUSTSTORE_LOCATION_PROP)) {
+ setUpSSLStores();
+ }
+ }
+
+ private void setUpSSLStores() {
+ SSLContextBuilder sslContextBuilder = SSLContexts.custom();
+ try {
+ if (config.containsKey(Config.SSL_TRUSTSTORE_LOCATION_PROP)) {
+ sslContextBuilder.loadTrustMaterial(
+ new File(config.getString(Config.SSL_TRUSTSTORE_LOCATION_PROP)),
+ config.getString(Config.SSL_TRUSTSTORE_PASSWORD_PROP).toCharArray(),
+ new TrustSelfSignedStrategy());
+ }
+ if (config.containsKey(Config.SSL_KEYSTORE_LOCATION_PROP)) {
+ sslContextBuilder.loadKeyMaterial(
+ new File(config.getString(Config.SSL_KEYSTORE_LOCATION_PROP)),
+ config.getString(Config.SSL_KEYSTORE_PASSWORD_PROP).toCharArray(),
+ config.getString(Config.SSL_KEY_PASSWORD_PROP).toCharArray()
+ );
+ }
+ sslSocketFactory = sslContextBuilder.build().getSocketFactory();
+ } catch (UnrecoverableKeyException | IOException | KeyStoreException | NoSuchAlgorithmException | CertificateException | KeyManagementException e) {
+ throw new RuntimeException(e);
Review Comment:
Should we wrap in `HoodieIOException` instead of `RuntimeException`, after all it's file i/o?
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/schema/TestSchemaRegistryProvider.java:
##########
@@ -75,7 +76,7 @@ public void testGetSourceSchemaShouldRequestSchemaWithCreds() throws IOException
assertNotNull(actual);
assertEquals(actual, getExpectedSchema(json));
verify(spyUnderTest, times(1)).setAuthorizationHeader(eq(basicAuth),
- Mockito.any(HttpURLConnection.class));
+ Mockito.any(HttpsURLConnection.class));
Review Comment:
This doesn't really test the `setUpSSLStores`. Does it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1403020957
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022",
"triggerID" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"triggerType" : "PUSH"
}, {
"hash" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14069",
"triggerID" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"triggerType" : "PUSH"
}, {
"hash" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14071",
"triggerID" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2c025ed416ea8607b2e6dcc116415f114f87b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14368",
"triggerID" : "f7b2c025ed416ea8607b2e6dcc116415f114f87b",
"triggerType" : "PUSH"
}, {
"hash" : "777e992653f094345bcadb5d0ad2125663f5340c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14596",
"triggerID" : "777e992653f094345bcadb5d0ad2125663f5340c",
"triggerType" : "PUSH"
}, {
"hash" : "0a0d47dacbb1815dc0f22e91ab39125a1fcc1993",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14614",
"triggerID" : "0a0d47dacbb1815dc0f22e91ab39125a1fcc1993",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0a0d47dacbb1815dc0f22e91ab39125a1fcc1993 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14614)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1385639846
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022",
"triggerID" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"triggerType" : "PUSH"
}, {
"hash" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14069",
"triggerID" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"triggerType" : "PUSH"
}, {
"hash" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14071",
"triggerID" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2c025ed416ea8607b2e6dcc116415f114f87b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f7b2c025ed416ea8607b2e6dcc116415f114f87b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b5f77ec23bb8e1532542dcb219a2ef567a1601e5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14071)
* f7b2c025ed416ea8607b2e6dcc116415f114f87b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #7576:
URL: https://github.com/apache/hudi/pull/7576#discussion_r1086036213
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/SchemaRegistryProvider.java:
##########
@@ -94,6 +121,33 @@ protected InputStream getStream(HttpURLConnection connection) throws IOException
public SchemaRegistryProvider(TypedProperties props, JavaSparkContext jssc) {
super(props, jssc);
DataSourceUtils.checkRequiredProperties(props, Collections.singletonList(Config.SRC_SCHEMA_REGISTRY_URL_PROP));
+ if (config.containsKey(Config.SSL_KEYSTORE_LOCATION_PROP)
+ || config.containsKey(Config.SSL_TRUSTSTORE_LOCATION_PROP)) {
+ setUpSSLStores();
+ }
+ }
+
+ private void setUpSSLStores() {
+ SSLContextBuilder sslContextBuilder = SSLContexts.custom();
+ try {
+ if (config.containsKey(Config.SSL_TRUSTSTORE_LOCATION_PROP)) {
+ sslContextBuilder.loadTrustMaterial(
+ new File(config.getString(Config.SSL_TRUSTSTORE_LOCATION_PROP)),
+ config.getString(Config.SSL_TRUSTSTORE_PASSWORD_PROP).toCharArray(),
+ new TrustSelfSignedStrategy());
+ }
+ if (config.containsKey(Config.SSL_KEYSTORE_LOCATION_PROP)) {
+ sslContextBuilder.loadKeyMaterial(
+ new File(config.getString(Config.SSL_KEYSTORE_LOCATION_PROP)),
+ config.getString(Config.SSL_KEYSTORE_PASSWORD_PROP).toCharArray(),
+ config.getString(Config.SSL_KEY_PASSWORD_PROP).toCharArray()
+ );
+ }
+ sslSocketFactory = sslContextBuilder.build().getSocketFactory();
+ } catch (UnrecoverableKeyException | IOException | KeyStoreException | NoSuchAlgorithmException | CertificateException | KeyManagementException e) {
+ throw new RuntimeException(e);
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7576: attempt at ssl implementation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1369254231
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022",
"triggerID" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"triggerType" : "PUSH"
}, {
"hash" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14069",
"triggerID" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"triggerType" : "PUSH"
}, {
"hash" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8cacccb9c7f7f753790bab885482b504bcc7919b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14069)
* b5f77ec23bb8e1532542dcb219a2ef567a1601e5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1402631293
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022",
"triggerID" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"triggerType" : "PUSH"
}, {
"hash" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14069",
"triggerID" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"triggerType" : "PUSH"
}, {
"hash" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14071",
"triggerID" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2c025ed416ea8607b2e6dcc116415f114f87b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14368",
"triggerID" : "f7b2c025ed416ea8607b2e6dcc116415f114f87b",
"triggerType" : "PUSH"
}, {
"hash" : "777e992653f094345bcadb5d0ad2125663f5340c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14596",
"triggerID" : "777e992653f094345bcadb5d0ad2125663f5340c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 777e992653f094345bcadb5d0ad2125663f5340c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14596)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1402847315
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022",
"triggerID" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"triggerType" : "PUSH"
}, {
"hash" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14069",
"triggerID" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"triggerType" : "PUSH"
}, {
"hash" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14071",
"triggerID" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2c025ed416ea8607b2e6dcc116415f114f87b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14368",
"triggerID" : "f7b2c025ed416ea8607b2e6dcc116415f114f87b",
"triggerType" : "PUSH"
}, {
"hash" : "777e992653f094345bcadb5d0ad2125663f5340c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14596",
"triggerID" : "777e992653f094345bcadb5d0ad2125663f5340c",
"triggerType" : "PUSH"
}, {
"hash" : "0a0d47dacbb1815dc0f22e91ab39125a1fcc1993",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14614",
"triggerID" : "0a0d47dacbb1815dc0f22e91ab39125a1fcc1993",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 777e992653f094345bcadb5d0ad2125663f5340c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14596)
* 0a0d47dacbb1815dc0f22e91ab39125a1fcc1993 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14614)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan merged PR #7576:
URL: https://github.com/apache/hudi/pull/7576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1402347867
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022",
"triggerID" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"triggerType" : "PUSH"
}, {
"hash" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14069",
"triggerID" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"triggerType" : "PUSH"
}, {
"hash" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14071",
"triggerID" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2c025ed416ea8607b2e6dcc116415f114f87b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14368",
"triggerID" : "f7b2c025ed416ea8607b2e6dcc116415f114f87b",
"triggerType" : "PUSH"
}, {
"hash" : "777e992653f094345bcadb5d0ad2125663f5340c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "777e992653f094345bcadb5d0ad2125663f5340c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7b2c025ed416ea8607b2e6dcc116415f114f87b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14368)
* 777e992653f094345bcadb5d0ad2125663f5340c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1402842300
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022",
"triggerID" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"triggerType" : "PUSH"
}, {
"hash" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14069",
"triggerID" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"triggerType" : "PUSH"
}, {
"hash" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14071",
"triggerID" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2c025ed416ea8607b2e6dcc116415f114f87b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14368",
"triggerID" : "f7b2c025ed416ea8607b2e6dcc116415f114f87b",
"triggerType" : "PUSH"
}, {
"hash" : "777e992653f094345bcadb5d0ad2125663f5340c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14596",
"triggerID" : "777e992653f094345bcadb5d0ad2125663f5340c",
"triggerType" : "PUSH"
}, {
"hash" : "0a0d47dacbb1815dc0f22e91ab39125a1fcc1993",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0d47dacbb1815dc0f22e91ab39125a1fcc1993",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 777e992653f094345bcadb5d0ad2125663f5340c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14596)
* 0a0d47dacbb1815dc0f22e91ab39125a1fcc1993 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1385651791
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022",
"triggerID" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"triggerType" : "PUSH"
}, {
"hash" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14069",
"triggerID" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"triggerType" : "PUSH"
}, {
"hash" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14071",
"triggerID" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2c025ed416ea8607b2e6dcc116415f114f87b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14368",
"triggerID" : "f7b2c025ed416ea8607b2e6dcc116415f114f87b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b5f77ec23bb8e1532542dcb219a2ef567a1601e5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14071)
* f7b2c025ed416ea8607b2e6dcc116415f114f87b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14368)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1386090331
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022",
"triggerID" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"triggerType" : "PUSH"
}, {
"hash" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14069",
"triggerID" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"triggerType" : "PUSH"
}, {
"hash" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14071",
"triggerID" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2c025ed416ea8607b2e6dcc116415f114f87b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14368",
"triggerID" : "f7b2c025ed416ea8607b2e6dcc116415f114f87b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7b2c025ed416ea8607b2e6dcc116415f114f87b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14368)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7576: attempt at ssl implementation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1366814866
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022",
"triggerID" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f665a724e2450d7c27f6e3d44bb443404f114036 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1369255643
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022",
"triggerID" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"triggerType" : "PUSH"
}, {
"hash" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14069",
"triggerID" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"triggerType" : "PUSH"
}, {
"hash" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14071",
"triggerID" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8cacccb9c7f7f753790bab885482b504bcc7919b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14069)
* b5f77ec23bb8e1532542dcb219a2ef567a1601e5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14071)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1403222093
CI is green
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7576: attempt at ssl implementation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1366896230
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022",
"triggerID" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f665a724e2450d7c27f6e3d44bb443404f114036 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] CTTY commented on a diff in pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by GitBox <gi...@apache.org>.
CTTY commented on code in PR #7576:
URL: https://github.com/apache/hudi/pull/7576#discussion_r1071718398
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/SchemaRegistryProvider.java:
##########
@@ -64,24 +81,32 @@ public static class Config {
* @throws IOException
*/
public String fetchSchemaFromRegistry(String registryUrl) throws IOException {
- URL registry;
HttpURLConnection connection;
Matcher matcher = Pattern.compile("://(.*?)@").matcher(registryUrl);
if (matcher.find()) {
String creds = matcher.group(1);
String urlWithoutCreds = registryUrl.replace(creds + "@", "");
- registry = new URL(urlWithoutCreds);
- connection = (HttpURLConnection) registry.openConnection();
+ connection = getConnection(urlWithoutCreds);
setAuthorizationHeader(matcher.group(1), connection);
} else {
- registry = new URL(registryUrl);
- connection = (HttpURLConnection) registry.openConnection();
+ connection = getConnection(registryUrl);
}
ObjectMapper mapper = new ObjectMapper();
JsonNode node = mapper.readTree(getStream(connection));
return node.get("schema").asText();
}
+ protected HttpURLConnection getConnection(String url) throws IOException {
+ URL registry = new URL(url);
+ if (sslSocketFactory != null) {
+ // we cannot cast to HttpsURLConnection if url is http so only cast when sslSocketFactory is set
+ HttpsURLConnection connection = (HttpsURLConnection) registry.openConnection();
+ connection.setSSLSocketFactory((sslSocketFactory));
Review Comment:
Why do we need double parentheses here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7576: attempt at ssl implementation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1369138471
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022",
"triggerID" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"triggerType" : "PUSH"
}, {
"hash" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f665a724e2450d7c27f6e3d44bb443404f114036 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022)
* 8cacccb9c7f7f753790bab885482b504bcc7919b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1377834492
Can you check CI failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7576: attempt at ssl implementation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1366811749
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f665a724e2450d7c27f6e3d44bb443404f114036 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1369313603
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022",
"triggerID" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"triggerType" : "PUSH"
}, {
"hash" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14069",
"triggerID" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"triggerType" : "PUSH"
}, {
"hash" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14071",
"triggerID" : "b5f77ec23bb8e1532542dcb219a2ef567a1601e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b5f77ec23bb8e1532542dcb219a2ef567a1601e5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14071)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7576: attempt at ssl implementation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7576:
URL: https://github.com/apache/hudi/pull/7576#issuecomment-1369209571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14022",
"triggerID" : "f665a724e2450d7c27f6e3d44bb443404f114036",
"triggerType" : "PUSH"
}, {
"hash" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14069",
"triggerID" : "8cacccb9c7f7f753790bab885482b504bcc7919b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8cacccb9c7f7f753790bab885482b504bcc7919b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14069)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] jonvex commented on a diff in pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by "jonvex (via GitHub)" <gi...@apache.org>.
jonvex commented on code in PR #7576:
URL: https://github.com/apache/hudi/pull/7576#discussion_r1084216989
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/schema/TestSchemaRegistryProvider.java:
##########
@@ -75,7 +76,7 @@ public void testGetSourceSchemaShouldRequestSchemaWithCreds() throws IOException
assertNotNull(actual);
assertEquals(actual, getExpectedSchema(json));
verify(spyUnderTest, times(1)).setAuthorizationHeader(eq(basicAuth),
- Mockito.any(HttpURLConnection.class));
+ Mockito.any(HttpsURLConnection.class));
Review Comment:
No. To test, I found an ssl client server example online and modified it to match the structure of schemaRegistryProvider and got that to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] CTTY commented on a diff in pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by GitBox <gi...@apache.org>.
CTTY commented on code in PR #7576:
URL: https://github.com/apache/hudi/pull/7576#discussion_r1071715993
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/SchemaRegistryProvider.java:
##########
@@ -94,6 +119,35 @@ protected InputStream getStream(HttpURLConnection connection) throws IOException
public SchemaRegistryProvider(TypedProperties props, JavaSparkContext jssc) {
super(props, jssc);
DataSourceUtils.checkRequiredProperties(props, Collections.singletonList(Config.SRC_SCHEMA_REGISTRY_URL_PROP));
+ if (config.containsKey(Config.SSL_KEYSTORE_LOCATION_PROP)
+ || config.containsKey(Config.SSL_TRUSTSTORE_LOCATION_PROP)) {
+ setUpSSLStores();
+ }
+ }
+
+ private SSLSocketFactory sslSocketFactory;
Review Comment:
nit: this variable is used at L101, moving this up would help avoid confusion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] jonvex commented on a diff in pull request #7576: [HUDI-4991] Allow kafka-like configs to set truststore and keystore for the SchemaProvider
Posted by GitBox <gi...@apache.org>.
jonvex commented on code in PR #7576:
URL: https://github.com/apache/hudi/pull/7576#discussion_r1072341098
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/SchemaRegistryProvider.java:
##########
@@ -64,24 +81,32 @@ public static class Config {
* @throws IOException
*/
public String fetchSchemaFromRegistry(String registryUrl) throws IOException {
- URL registry;
HttpURLConnection connection;
Matcher matcher = Pattern.compile("://(.*?)@").matcher(registryUrl);
if (matcher.find()) {
String creds = matcher.group(1);
String urlWithoutCreds = registryUrl.replace(creds + "@", "");
- registry = new URL(urlWithoutCreds);
- connection = (HttpURLConnection) registry.openConnection();
+ connection = getConnection(urlWithoutCreds);
setAuthorizationHeader(matcher.group(1), connection);
} else {
- registry = new URL(registryUrl);
- connection = (HttpURLConnection) registry.openConnection();
+ connection = getConnection(registryUrl);
}
ObjectMapper mapper = new ObjectMapper();
JsonNode node = mapper.readTree(getStream(connection));
return node.get("schema").asText();
}
+ protected HttpURLConnection getConnection(String url) throws IOException {
+ URL registry = new URL(url);
+ if (sslSocketFactory != null) {
+ // we cannot cast to HttpsURLConnection if url is http so only cast when sslSocketFactory is set
+ HttpsURLConnection connection = (HttpsURLConnection) registry.openConnection();
+ connection.setSSLSocketFactory((sslSocketFactory));
Review Comment:
We don't. Good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org