You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/01/23 23:19:14 UTC
Review Request 30229: Stacks API structure changes when timestamp is
applied
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30229/
-----------------------------------------------------------
Review request for Ambari and John Speidel.
Bugs: AMBARI-9311
https://issues.apache.org/jira/browse/AMBARI-9311
Repository: ambari
Description
-------
A Stacks API call made without timestamp and with timsestamp returns with different response:
http://c6401.ambari.apache.org:8080/api/v1/stacks/HDP/versions/2.2/services?fields=StackServices/*,serviceComponents/*,serviceComponents/dependencies/Dependencies/scope
http://c6401.ambari.apache.org:8080/api/v1/stacks/HDP/versions/2.2/services?fields=StackServices/*,serviceComponents/*,serviceComponents/dependencies/Dependencies/scope&_=
The element in the items array has a field *components* in the call without timestamp and *serviceComponents* in the call with timestamp
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseStacksResourceDefinition.java 6bff79c
ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseStacksResourceDefinitionTest.java b235876
Diff: https://reviews.apache.org/r/30229/diff/
Testing
-------
Manual test.
Added new unit test.
Existing tests pass.
Thanks,
Tom Beerbower
Re: Review Request 30229: Stacks API structure changes when timestamp
is applied
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30229/#review69805
-----------------------------------------------------------
Ship it!
I am glad to see the api using the new endpoint names.
Now we should be able to remove the old stacks2 api.
- John Speidel
On Jan. 27, 2015, 12:38 a.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30229/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2015, 12:38 a.m.)
>
>
> Review request for Ambari, John Speidel and Nate Cole.
>
>
> Bugs: AMBARI-9311
> https://issues.apache.org/jira/browse/AMBARI-9311
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A Stacks API call made without timestamp and with timsestamp returns with different response:
> http://c6401.ambari.apache.org:8080/api/v1/stacks/HDP/versions/2.2/services?fields=StackServices/*,serviceComponents/*,serviceComponents/dependencies/Dependencies/scope
>
> http://c6401.ambari.apache.org:8080/api/v1/stacks/HDP/versions/2.2/services?fields=StackServices/*,serviceComponents/*,serviceComponents/dependencies/Dependencies/scope&_=
>
> The element in the items array has a field *components* in the call without timestamp and *serviceComponents* in the call with timestamp
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseStacksResourceDefinition.java 6bff79c
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseStacksResourceDefinitionTest.java b235876
>
> Diff: https://reviews.apache.org/r/30229/diff/
>
>
> Testing
> -------
>
> Manual test.
>
> Added new unit test.
>
> Existing tests pass.
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 30229: Stacks API structure changes when timestamp
is applied
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30229/#review69792
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Jan. 26, 2015, 7:38 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30229/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2015, 7:38 p.m.)
>
>
> Review request for Ambari, John Speidel and Nate Cole.
>
>
> Bugs: AMBARI-9311
> https://issues.apache.org/jira/browse/AMBARI-9311
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A Stacks API call made without timestamp and with timsestamp returns with different response:
> http://c6401.ambari.apache.org:8080/api/v1/stacks/HDP/versions/2.2/services?fields=StackServices/*,serviceComponents/*,serviceComponents/dependencies/Dependencies/scope
>
> http://c6401.ambari.apache.org:8080/api/v1/stacks/HDP/versions/2.2/services?fields=StackServices/*,serviceComponents/*,serviceComponents/dependencies/Dependencies/scope&_=
>
> The element in the items array has a field *components* in the call without timestamp and *serviceComponents* in the call with timestamp
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseStacksResourceDefinition.java 6bff79c
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseStacksResourceDefinitionTest.java b235876
>
> Diff: https://reviews.apache.org/r/30229/diff/
>
>
> Testing
> -------
>
> Manual test.
>
> Added new unit test.
>
> Existing tests pass.
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 30229: Stacks API structure changes when timestamp
is applied
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30229/
-----------------------------------------------------------
(Updated Jan. 27, 2015, 12:38 a.m.)
Review request for Ambari, John Speidel and Nate Cole.
Bugs: AMBARI-9311
https://issues.apache.org/jira/browse/AMBARI-9311
Repository: ambari
Description
-------
A Stacks API call made without timestamp and with timsestamp returns with different response:
http://c6401.ambari.apache.org:8080/api/v1/stacks/HDP/versions/2.2/services?fields=StackServices/*,serviceComponents/*,serviceComponents/dependencies/Dependencies/scope
http://c6401.ambari.apache.org:8080/api/v1/stacks/HDP/versions/2.2/services?fields=StackServices/*,serviceComponents/*,serviceComponents/dependencies/Dependencies/scope&_=
The element in the items array has a field *components* in the call without timestamp and *serviceComponents* in the call with timestamp
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseStacksResourceDefinition.java 6bff79c
ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseStacksResourceDefinitionTest.java b235876
Diff: https://reviews.apache.org/r/30229/diff/
Testing
-------
Manual test.
Added new unit test.
Existing tests pass.
Thanks,
Tom Beerbower