[jira] [Commented] (GEODE-2828) AEQ needs to be created before the user region

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991141#comment-15991141 ] 

ASF GitHub Bot commented on GEODE-2828:
---------------------------------------

Github user upthewaterspout commented on a diff in the pull request:

    https://github.com/apache/geode/pull/481#discussion_r114158872
  
    --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegion.java ---
    @@ -78,17 +87,9 @@ protected RepositoryManager createRepositoryManager() {
         // create PR fileAndChunkRegion, but not to create its buckets for now
         final String fileRegionName = createFileRegionName();
         PartitionAttributes partitionAttributes = dataRegion.getPartitionAttributes();
    -
    -
    -    // create PR chunkRegion, but not to create its buckets for now
    -
    -    // we will create RegionDirectories on the fly when data comes in
    -    HeterogeneousLuceneSerializer mapper = new HeterogeneousLuceneSerializer(getFieldNames());
    -    PartitionedRepositoryManager partitionedRepositoryManager =
    -        new PartitionedRepositoryManager(this, mapper);
         DM dm = this.cache.getInternalDistributedSystem().getDistributionManager();
         LuceneBucketListener lucenePrimaryBucketListener =
    -        new LuceneBucketListener(partitionedRepositoryManager, dm);
    +        new LuceneBucketListener((PartitionedRepositoryManager) partitionedRepositoryManager, dm);
    --- End diff --
    
    Having to cast is a bit of a bad smell here. It seems like either LuceneBucketListener should take an AbstractPartitionedRepositoryManager, or createLuceneListenersAndFileChunkRegions should have been passed in a PartitionRespositoryManager.


> AEQ needs to be created before the user region
> ----------------------------------------------
>
>                 Key: GEODE-2828
>                 URL: https://issues.apache.org/jira/browse/GEODE-2828
>             Project: Geode
>          Issue Type: Bug
>          Components: lucene
>            Reporter: nabarun
>
> Issue:
> Events are lost as the region is being created, because the AEQ gets created after the user region is created, and the indexes are not being created via AEQ.
> Solution:
> 1. AEQ being created before the user region.
> 2. Processing of lucene events are being halted by a countdown latch and starts processing after the user region is created.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)