You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltacloud.apache.org by mf...@redhat.com on 2012/07/18 18:03:56 UTC
[PATCH core 3/7] Core: Added X-Deltacloud-Provider and X-Deltacloud-Driver header to HTTP response
From: Michal Fojtik <mf...@redhat.com>
Signed-off-by: Michal fojtik <mf...@redhat.com>
---
server/lib/deltacloud/helpers.rb | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/server/lib/deltacloud/helpers.rb b/server/lib/deltacloud/helpers.rb
index 0c66103..6566c59 100644
--- a/server/lib/deltacloud/helpers.rb
+++ b/server/lib/deltacloud/helpers.rb
@@ -66,6 +66,10 @@ module Deltacloud::Collections
after do
headers 'Server' => 'Apache-Deltacloud/' + settings.version
+ headers 'X-Deltacloud-Driver' => driver_name
+ if provider_name
+ headers 'X-Deltacloud-Provider' => provider_name
+ end
end
def self.new_route_for(route, &block)
--
1.7.10.2
Re: [PATCH core 3/7] Core: Added X-Deltacloud-Provider and
X-Deltacloud-Driver header to HTTP response
Posted by David Lutterkort <lu...@redhat.com>.
On Wed, 2012-07-18 at 18:03 +0200, mfojtik@redhat.com wrote:
> From: Michal Fojtik <mf...@redhat.com>
>
>
> Signed-off-by: Michal fojtik <mf...@redhat.com>
> ---
> server/lib/deltacloud/helpers.rb | 4 ++++
> 1 file changed, 4 insertions(+)
ACK; the first line of the commit message is too long though, and the
commit message needs to explain why this change was made.
And while we are on the subject of testing: where is the test that
checks these headers are set properly ?
David