[GitHub] geode pull request #698: Mark ProtoBuf interface as experimental

[pivotal-amurmann <gi...@git.apache.org>]

GitHub user pivotal-amurmann opened a pull request:

    https://github.com/apache/geode/pull/698

    Mark ProtoBuf interface as experimental

    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    3042
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    N/A
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    N/A
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pivotal-amurmann/geode chore/GEODE-3402

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/698.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #698
    
----
commit 26425bb0ce0cb0936fe0c0534abf5f1f5eac0e05
Author: Bruce Schuchardt <bs...@pivotal.io>
Date:   2017-08-08T23:29:29Z

    Mark ProtoBuf interface as experimental
    
    Signed-off-by: Alexander Murmann <am...@pivotal.io>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #698: Mark ProtoBuf interface as experimental

[galen-pivotal <gi...@git.apache.org>]

Github user galen-pivotal commented on the issue:

    https://github.com/apache/geode/pull/698
  
    What you've done looks good. However, it looks like there are ten or so files in `geode-protobuf` that you didn't mark as experimental. Is there a reason for this?
    
    Have a look at the difference between these:
    
    ```bash
    find geode-protobuf/src/main/ -name '*.java' 
    find geode-protobuf/src/main/ -name '*.java' | xargs grep -l '@Experimental'
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #698: Mark ProtoBuf interface as experimental

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/geode/pull/698


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---