[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8981: add query metrics for broker parallel merges, off by default

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #8981: add query metrics for broker parallel merges, off by default
URL: https://github.com/apache/incubator-druid/pull/8981#discussion_r353502939
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
 ##########
 @@ -575,21 +617,22 @@ protected void compute()
               adjustedNextYieldAfter,
               batchSize,
               targetTimeNanos,
-              recursionDepth + 1,
+              metricsAccumulator,
               cancellationGizmo
           ));
         } else if (cancellationGizmo.isCancelled()) {
           // if we got the cancellation signal, go ahead and write terminal value into output queue to help gracefully
           // allow downstream stuff to stop
-          LOG.debug("cancelled after %s tasks", recursionDepth);
+          LOG.debug("cancelled after %s tasks", metricsAccumulator.getTaskCount());
           outputQueue.offer(ResultBatch.TERMINAL);
         } else {
           // if priority queue is empty, push the final accumulated value into the output batch and push it out
           outputBatch.add(currentCombinedValue);
+          metricsAccumulator.incrementOutputRows(batchCounter + 1L);
 
 Review comment:
   No, it is for the straggling `currentCombinedValue` that is being added to the batch the line before, which comes from here if the inputs were exhausted: https://github.com/apache/incubator-druid/blob/master/core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java#L537

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org