You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/16 15:43:15 UTC
[GitHub] [incubator-superset] kkucharc opened a new pull request #10911: Fix: url parameter was covering class parameter
kkucharc opened a new pull request #10911:
URL: https://github.com/apache/incubator-superset/pull/10911
# SUMMARY
Suggestion of renaming `url` parameter in `models/core.py`:
- removed disabled pylint rule: `redefined-outer-name` from file
- url parameter is renamed in several methods so it's not misleading in code.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #10911: fix: url parameter was covering class parameter
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #10911:
URL: https://github.com/apache/incubator-superset/pull/10911
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kkucharc commented on pull request #10911: fix: url parameter was covering class parameter
Posted by GitBox <gi...@apache.org>.
kkucharc commented on pull request #10911:
URL: https://github.com/apache/incubator-superset/pull/10911#issuecomment-693537460
@mistercrunch Thank you for review. I just applied changes from master to see if my PR doesn't break anything. CC: @willbarrett
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org