You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/08 18:22:48 UTC
[GitHub] [superset] pkdotson opened a new pull request #15593: refactor: icon to icons for sqllab
pkdotson opened a new pull request #15593:
URL: https://github.com/apache/superset/pull/15593
### SUMMARY
This pr migrates the icons in sqllab editor to the new icons component.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
<img width="466" alt="Screen Shot 2021-07-08 at 6 29 50 AM" src="https://user-images.githubusercontent.com/17326228/124971897-9aeeb100-dfde-11eb-9a21-bd7b8f4509ad.png">
<img width="131" alt="1 SAVE AS" src="https://user-images.githubusercontent.com/17326228/124971990-ae018100-dfde-11eb-8a7d-83d90b6a5a1f.png">
<img width="128" alt="COPY LINK" src="https://user-images.githubusercontent.com/17326228/124972028-bbb70680-dfde-11eb-9646-19644ec094ab.png">
after
<img width="375" alt="Screen Shot 2021-07-08 at 7 16 05 AM" src="https://user-images.githubusercontent.com/17326228/124971927-a0e49200-dfde-11eb-8985-1db477d7a4e2.png">
<img width="118" alt="SAVE AS" src="https://user-images.githubusercontent.com/17326228/124972007-b3f76200-dfde-11eb-975c-ccf25450fb9a.png">
<img width="123" alt="2 COPY LINK" src="https://user-images.githubusercontent.com/17326228/124972051-c2de1480-dfde-11eb-8bdd-41846d295169.png">
### TESTING INSTRUCTIONS
Go to sql editor to check out icons
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15593: refactor: icon to icons for sqllab
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #15593:
URL: https://github.com/apache/superset/pull/15593#issuecomment-877485621
# [Codecov](https://codecov.io/gh/apache/superset/pull/15593?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15593](https://codecov.io/gh/apache/superset/pull/15593?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (385c431) into [master](https://codecov.io/gh/apache/superset/commit/86a59a292725f70336e3fa7c1109fec15103fdad?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86a59a2) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/15593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15593 +/- ##
==========================================
- Coverage 76.87% 76.86% -0.01%
==========================================
Files 976 976
Lines 51292 51302 +10
Branches 6907 6912 +5
==========================================
+ Hits 39430 39434 +4
- Misses 11643 11647 +4
- Partials 219 221 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.41% <100.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/15593/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `65.11% <100.00%> (+0.83%)` | :arrow_up: |
| [...erset-frontend/src/SqlLab/components/SaveQuery.tsx](https://codecov.io/gh/apache/superset/pull/15593/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVRdWVyeS50c3g=) | `75.55% <100.00%> (+1.13%)` | :arrow_up: |
| [...rontend/src/SqlLab/components/ShareSqlLabQuery.tsx](https://codecov.io/gh/apache/superset/pull/15593/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NoYXJlU3FsTGFiUXVlcnkudHN4) | `88.37% <100.00%> (ø)` | |
| [...tend/src/views/CRUD/annotation/AnnotationModal.tsx](https://codecov.io/gh/apache/superset/pull/15593/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTW9kYWwudHN4) | `60.44% <0.00%> (-2.52%)` | :arrow_down: |
| [...s/CRUD/data/database/DatabaseModal/ModalHeader.tsx](https://codecov.io/gh/apache/superset/pull/15593/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL01vZGFsSGVhZGVyLnRzeA==) | `89.18% <0.00%> (-2.48%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/15593/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `72.46% <0.00%> (-2.17%)` | :arrow_down: |
| [...c/views/CRUD/data/database/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/15593/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `47.41% <0.00%> (-0.45%)` | :arrow_down: |
| [...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx](https://codecov.io/gh/apache/superset/pull/15593/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJNb2RhbC50c3g=) | `69.47% <0.00%> (-0.32%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplateModal.tsx](https://codecov.io/gh/apache/superset/pull/15593/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlTW9kYWwudHN4) | `67.30% <0.00%> (-0.32%)` | :arrow_down: |
| [...et-frontend/src/messageToasts/components/Toast.tsx](https://codecov.io/gh/apache/superset/pull/15593/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdC50c3g=) | `92.50% <0.00%> (-0.19%)` | :arrow_down: |
| ... and [12 more](https://codecov.io/gh/apache/superset/pull/15593/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15593?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15593?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86a59a2...385c431](https://codecov.io/gh/apache/superset/pull/15593?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian commented on a change in pull request #15593: refactor: icon to icons for sqllab
Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #15593:
URL: https://github.com/apache/superset/pull/15593#discussion_r667245861
##########
File path: superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx
##########
@@ -39,6 +39,16 @@ interface ShareSqlLabQueryPropTypes {
addDangerToast: (msg: string) => void;
}
+const SytledIcon = styled(Icons.Link)`
Review comment:
typo: StyledIcon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian commented on pull request #15593: refactor: icon to icons for sqllab
Posted by GitBox <gi...@apache.org>.
suddjian commented on pull request #15593:
URL: https://github.com/apache/superset/pull/15593#issuecomment-877497739
Approved with typo corrections
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian commented on a change in pull request #15593: refactor: icon to icons for sqllab
Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #15593:
URL: https://github.com/apache/superset/pull/15593#discussion_r667245861
##########
File path: superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx
##########
@@ -39,6 +39,16 @@ interface ShareSqlLabQueryPropTypes {
addDangerToast: (msg: string) => void;
}
+const SytledIcon = styled(Icons.Link)`
Review comment:
typo: StyledIcon
```suggestion
const SyledIcon = styled(Icons.Link)`
```
##########
File path: superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx
##########
@@ -39,6 +39,16 @@ interface ShareSqlLabQueryPropTypes {
addDangerToast: (msg: string) => void;
}
+const SytledIcon = styled(Icons.Link)`
Review comment:
typo: StyledIcon
```suggestion
const StyledIcon = styled(Icons.Link)`
```
##########
File path: superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx
##########
@@ -86,14 +96,12 @@ function ShareSqlLabQuery({
: t('Save the query to enable this feature');
return (
<Button buttonSize="small" tooltip={tooltip} disabled={!canShare}>
- <Icon
- name="link"
+ <SytledIcon
Review comment:
```suggestion
<StyledIcon
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #15593: refactor: icon to icons for sqllab
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #15593:
URL: https://github.com/apache/superset/pull/15593#discussion_r667332565
##########
File path: superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx
##########
@@ -86,14 +96,12 @@ function ShareSqlLabQuery({
: t('Save the query to enable this feature');
return (
<Button buttonSize="small" tooltip={tooltip} disabled={!canShare}>
- <Icon
- name="link"
+ <SytledIcon
color={
Review comment:
```suggestion
iconColor={
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15593: refactor: icon to icons for sqllab
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15593:
URL: https://github.com/apache/superset/pull/15593#issuecomment-877485621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson merged pull request #15593: refactor: icon to icons for sqllab
Posted by GitBox <gi...@apache.org>.
pkdotson merged pull request #15593:
URL: https://github.com/apache/superset/pull/15593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org